Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActivityMetadata entity #1577

Merged
merged 1 commit into from
May 21, 2024
Merged

Update ActivityMetadata entity #1577

merged 1 commit into from
May 21, 2024

Conversation

iamacook
Copy link
Member

Summary

The ActivityMetadata was defined whilst it was being developed on the Locking Service. Now that the service has included it, it does not match and therefore does not pass validation.

This aligns entity by removing resourceId and changing maxPoints to a number.

Changes

  • Remove resourceId and change maxPoints to number in ActivityMetadataSchema
  • Update ActivityMetadata to reflect changes
  • Update tests accordingly

@iamacook iamacook self-assigned this May 21, 2024
@iamacook iamacook requested a review from a team as a code owner May 21, 2024 08:49
@iamacook iamacook merged commit 2f8f638 into main May 21, 2024
16 checks passed
@iamacook iamacook deleted the activity-metadata branch May 21, 2024 08:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9171743230

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 92.834%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 3 60.0%
Totals Coverage Status
Change from base Build 9170744247: -0.07%
Covered Lines: 7108
Relevant Lines: 7364

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants