-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Account
implementation and integration
#1652
Conversation
Pull Request Test Coverage Report for Build 9513954877Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9514300114Details
💛 - Coveralls |
src/config/entities/configuration.ts
Outdated
process.env.EMAIL_VERIFICATION_CODE_TTL_MS ?? `${5 * 60 * 1000}`, | ||
), | ||
}, | ||
// TODO: Decide whether we reuse these when implementing the email service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: not an strong opinion, but I'd more in favour of deleting this code instead of commenting it. We can back to the commits history if we need to reuse this. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 7e7818d.
Adds a new datasource for accounts, implementing a basic database with tables for `accounts` and `groups`: - Create `00001_accounts` migration to create database - Create `Account` entity with test coverage - Create `Group` entity with test coverage - Create `IAccountsDatasource` with implementation and test override
Pull Request Test Coverage Report for Build 9517736861Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9517797503Details
💛 - Coveralls |
Summary
The current account implementation was built according to email notifications. As we are now putting more focus on accounts as a fundamental feature, we are reassessing the implementation.
This removes the current account/subscription integration, as well as their integration with alerts and emails.
Changes