Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SetPreSignatureDecoder and usage to GPv2Decoder #1671

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

iamacook
Copy link
Member

Summary

We will need to debug more methods on the GPv2Settlement contract for #1650 and therefore create relevant decoders for. Currently, we have a SetPreSignatureDecoder which specifically interacts with this contract.

This renames it and usage of it to GPv2Decoder, which also matches the style across the project for other decoders.

@iamacook iamacook self-assigned this Jun 18, 2024
@iamacook iamacook requested a review from a team as a code owner June 18, 2024 14:31
@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9566991952

Details

  • 9 of 13 (69.23%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.406%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/helpers/swap-order.helper.ts 2 3 66.67%
src/routes/transactions/mappers/common/swap-order.mapper.ts 2 3 66.67%
src/routes/transactions/transactions-view.service.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 9563691273: 0.0%
Covered Lines: 3971
Relevant Lines: 6464

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9568438597

Details

  • 9 of 13 (69.23%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 49.451%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/helpers/swap-order.helper.ts 2 3 66.67%
src/routes/transactions/mappers/common/swap-order.mapper.ts 2 3 66.67%
src/routes/transactions/transactions-view.service.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 9563691273: 0.05%
Covered Lines: 3973
Relevant Lines: 6464

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9578954443

Details

  • 9 of 13 (69.23%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.274%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/helpers/swap-order.helper.ts 2 3 66.67%
src/routes/transactions/mappers/common/swap-order.mapper.ts 2 3 66.67%
src/routes/transactions/transactions-view.service.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 9578682874: 0.0%
Covered Lines: 4068
Relevant Lines: 6658

💛 - Coveralls

@iamacook iamacook merged commit 8953349 into main Jun 19, 2024
16 checks passed
@iamacook iamacook deleted the rename-set-pre-sig-decoder branch June 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants