Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional CGW_ENV attribute to the configuration #1704

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This is motivated by the necessity of having different auth cookie configurations per environment, so the CGW needs a configuration value specifying the current environment at runtime.

Changes

  • Add optional CGW_ENV attribute to the configuration.
  • Moves the applicationPort attribute along with the new one to an application node in the configuration schema.

@hectorgomezv hectorgomezv self-assigned this Jun 28, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner June 28, 2024 14:44
@hectorgomezv hectorgomezv merged commit ad3805b into main Jun 28, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the add-cgw-env-attribute branch June 28, 2024 14:56
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9714645448

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 48.778%

Totals Coverage Status
Change from base Build 9714013415: 0.01%
Covered Lines: 4195
Relevant Lines: 6937

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants