Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Settings on Account/DataType deletion #1748

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Delete Settings on Account/DataType deletion #1748

merged 1 commit into from
Jul 10, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This PR adds a database trigger to cascade delete account_data_settings rows associated with the account or account_data_type being deleted.

Changes

  • Adds ON DELETE CASCADE triggers to both account_data_settings.account_id and account_data_settings.account_data_type_id fields foreign keys.
  • Adds migration tests verifying the triggers.

@hectorgomezv hectorgomezv self-assigned this Jul 10, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner July 10, 2024 10:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9872752019

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.124%
Totals Coverage Status
Change from base Build 9858819355: 0.0%
Covered Lines: 4244
Relevant Lines: 7078
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 890f405 into main Jul 10, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the trigger-account-cascade-deletion branch July 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorgomezv @coveralls @iamacook