Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chain[contractAddresses] property #1752

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Add Chain[contractAddresses] property #1752

merged 2 commits into from
Jul 15, 2024

Conversation

iamacook
Copy link
Member

⚠️ Depends on safe-global/safe-config-service#1175 from the Config Service.

Summary

When deploying the Safe infrastructure, it is currently necessary for a desired network to be present in our safe-deployments repo. as that is the source of truth for contract addresses.

In order to remove this hurdle, new (optional) fields for contract addresses to populate the ContractNetworksConfig of the protocol-kit for a given chain are to be added to the Config Service. This propagates the fields and validates them accordingly.

Changes

  • Add new ContractAddressesSchema, include it in ChainSchema and infer a new ContractAddresses entity from it
  • Add new contractAddressesBuilder and include it in chainBuilder
  • Add appropriate test coverage

@iamacook iamacook self-assigned this Jul 10, 2024
@iamacook iamacook requested a review from a team as a code owner July 10, 2024 15:02
@coveralls
Copy link

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 9936846516

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 48.129%

Totals Coverage Status
Change from base Build 9858819355: 0.005%
Covered Lines: 4245
Relevant Lines: 7079

💛 - Coveralls

@hectorgomezv hectorgomezv self-requested a review July 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants