Counterfactual Safes deletion endpoints #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controller.spec.ts Co-authored-by: Aaron Cook <aaron@safe.global>
…controller.spec.ts Co-authored-by: Aaron Cook <aaron@safe.global>
…controller.ts Co-authored-by: Aaron Cook <aaron@safe.global>
…unterfactual-safe.builder.ts Co-authored-by: Aaron Cook <aaron@safe.global>
hectorgomezv
changed the title
hectorgomezv
changed the title
Pull Request Test Coverage Report for Build 10217581347Details
💛 - Coveralls |
iamacook
reviewed
Jul 31, 2024
| ).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('returns 403 if chain_id is not a valid chain ID', async () => { |
There was a problem hiding this comment.
What do you think about adding another test case that ensure the token is valid if signed on a different chain?
src/routes/accounts/counterfactual-safes/counterfactual-safes.controller.spec.ts
Show resolved
Hide resolved
| @@ -584,4 +584,337 @@ describe('CounterfactualSafesController', () => { | |||
| ).not.toHaveBeenCalled(); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Delete Counterfactual Safe', () => { | |||
| it('should delete a Counterfactual Safe', async () => { | |||
There was a problem hiding this comment.
We should add test coverage regarding a datasource error. These assume that deletion was successful.
There was a problem hiding this comment.
Added in 650d3f6 (I've added that test also to the rest of endpoints)
iamacook
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1789
Summary
This PR adds a subset of the Counterfactual Safes storage controller endpoints. Specifically:
The first one deletes an existing Counterfactual Safe by the creator's account address, the chain ID, and the predicted address of the Safe to be deployed.
The second deletes all the Counterfactual Safes associated with the address, i.e.: the address being the creator of the Counterfactual Safes.
Changes
DELETE /v1/accounts/:address/storage/counterfactual-safes/:chainId/:predictedAddressDELETE /v1/accounts/:address/storage/counterfactual-safes