Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AUTH_VALIDITY_PERIOD_SECONDS as access token default validity #1817

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This PR modifies the service to take the value AUTH_VALIDITY_PERIOD_SECONDS from the configuration as a default value for the exp attribute of the issued JWTs (and also the maxAge) value for the auth cookies.

Changes

  • Takes AUTH_VALIDITY_PERIOD_SECONDS as the default value when not specified by the client on the SiWE message.
  • Increases the default for this value to 24 hours.

@hectorgomezv hectorgomezv self-assigned this Aug 9, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner August 9, 2024 15:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10322088723

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 46.907%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/domain/siwe/siwe.repository.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10304686649: -0.004%
Covered Lines: 4551
Relevant Lines: 7832

💛 - Coveralls

@iamacook iamacook merged commit 3be99bb into main Aug 12, 2024
16 checks passed
@iamacook iamacook deleted the set-max-validity-period-as-default branch August 12, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants