Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token metadata to Native Staking transactions #1859

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This PR adds TokenInfo metadata to Native Staking transaction mappings. This implies the TokenInfo metadata will be available in transaction Confirmation View and transaction history/queue.

Changes

  • Adds TokenInfo metadata to NativeStakingDepositTransactionInfo.
  • Adjusts unit tests accordingly.

@hectorgomezv hectorgomezv self-assigned this Aug 27, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner August 27, 2024 08:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10574620161

Details

  • 59 of 62 (95.16%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 46.768%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/entities/staking/native-staking-confirmation-view.entity.ts 3 4 75.0%
src/routes/transactions/entities/staking/native-staking-info.entity.ts 2 3 66.67%
src/routes/transactions/mappers/common/native-staking.mapper.ts 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/native-staking.mapper.ts 1 32.43%
Totals Coverage Status
Change from base Build 10561934475: 0.04%
Covered Lines: 4750
Relevant Lines: 8214

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 109d153 into main Aug 27, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the add-tokeninfo-to-confirmation-native-staking-views branch August 27, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TokenInfo data to confirmation/transaction native staking views
2 participants