Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numValidators to Native Staking confirmation view #1868

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add numValidators to Native Staking confirmation view #1868

merged 2 commits into from
Aug 28, 2024

Conversation

hectorgomezv
Copy link
Member

Closes #1867

Changes

  • Adds numValidators field to the Native Staking transaction confirmation view.

@hectorgomezv hectorgomezv self-assigned this Aug 28, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner August 28, 2024 10:09
@hectorgomezv hectorgomezv linked an issue Aug 28, 2024 that may be closed by this pull request
Add number of validators to Native Staking confirmation view #1867
Closed
@coveralls
Copy link

coveralls commented Aug 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10594719138

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 46.714%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/entities/staking/native-staking-confirmation-view.entity.ts 1 2 50.0%
src/routes/transactions/transactions-view.service.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 10594055881: 0.001%
Covered Lines: 4764
Relevant Lines: 8251
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 0cde218 into main Aug 28, 2024
18 checks passed
@hectorgomezv hectorgomezv deleted the add-number-of-validators branch August 28, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add number of validators to Native Staking confirmation view
2 participants
@hectorgomezv @coveralls