Avoid casting to determine confirmation state when mapping staking transactions

[iamacook]

Summary

When determining the confirmation state of native deposit transacitons, we currently cast a transaction that can be either aMultisigTransaction or ModuleTransaction to MultisigTransaction. It is still theoretically possible to deposit via a module, meaning that this cast is not safe.

This avoids casting and instead checks for the existence of the confirmations property in the transaction in question, inherently meaning that it is a MultisigTransaction.

Changes

• Check for confirmations property instead of casting

[coveralls]

Pull Request Test Coverage Report for Build 10612544702

Details

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 46.719%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/routes/transactions/mappers/common/transaction-info.mapper.ts	0	1	0.0%

Totals
Change from base Build 10597705364:	0.0%
Covered Lines:	4765
Relevant Lines:	8251

---

💛 - Coveralls

[hectorgomezv]

👏🏻👏🏻👏🏻 Thanks!