Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure route CreationTransaction correctly implements that of domain #1874

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

iamacook
Copy link
Member

Summary

The route-level CreationTransaction entity does not currently correctly implement that of the domain, e.g. addresses are not 0x${string} but string. This adjusts it to extend the CreationTransaction of the domain, adjusting the types accordingly.

Note: the associated changes to the data decoded entities were required to appease TypeScript.

Changes

  • Implement the domain-level CreationTransaction in the route-level entity
  • Implement the domain-level DataDecoded in the route-level entity
  • Implement the domain-level DataDecodedParameter in the route-level entity

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10612928331

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.719%

Totals Coverage Status
Change from base Build 10597705364: 0.0%
Covered Lines: 4765
Relevant Lines: 8252

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 5737356 into main Aug 29, 2024
18 checks passed
@hectorgomezv hectorgomezv deleted the creation-transaction-implementation branch August 29, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants