Ensure route CreationTransaction
correctly implements that of domain
#1874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The route-level
CreationTransaction
entity does not currently correctly implement that of the domain, e.g. addresses are not0x${string}
butstring
. This adjusts it to extend theCreationTransaction
of the domain, adjusting the types accordingly.Note: the associated changes to the data decoded entities were required to appease TypeScript.
Changes
CreationTransaction
in the route-level entityDataDecoded
in the route-level entityDataDecodedParameter
in the route-level entity