Set count as number of valid Page['results']
#1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Sep 2, 2024
| @@ -281,6 +284,31 @@ describe('Chains Controller (Unit)', () => { | |||
| }, | |||
| }); | |||
| }); | |||
|
|
|||
| it('Failure: received data is not valid', async () => { | |||
There was a problem hiding this comment.
This was previously in the suite but removed.
iamacook
commented
Sep 2, 2024
| /** | ||
| * Builds a lenient page schema that filters out invalid items from the results array. | ||
| */ | ||
| export function buildLenientPageSchema<T extends z.ZodTypeAny>( |
There was a problem hiding this comment.
I moved this to the factory file as the base schema was extracted to BasePageSchema.
Pull Request Test Coverage Report for Build 10664491020Details
💛 - Coveralls |
hectorgomezv
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Invalid
Page['results'][number]items are excluding in lenient page schemas, but remain in thePage['count']. This adjustsbuildLenientPageSchemato set thecountas the valid results arraylengthas per #1871 (comment).Changes
countas length of validPage['results']