Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployment comparison when finding via chain/address #1894

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Sep 4, 2024

Summary

Currently, we do not compare the chain ID of a deployment, as well as manually checksumming the address. This adds (and references) a new StakingRepository['getDeployments'] method which checksums the address for us, as well as updates StakingRepository['getDeployment'] to take the chainId into account when finding the deployment in question.

Changes

  • Add (and use) private getDeployments method.
  • Compare chainId in getDeployment.

@iamacook iamacook self-assigned this Sep 4, 2024
@iamacook iamacook requested a review from a team as a code owner September 4, 2024 06:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10696464350

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 46.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/domain/staking/staking.repository.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 10683977332: -0.02%
Covered Lines: 4811
Relevant Lines: 8366

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit ee97a2f into main Sep 4, 2024
18 checks passed
@hectorgomezv hectorgomezv deleted the staking-deployment-chainid branch September 4, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants