Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slashes from Transaction Service URLs #1930

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

iamacook
Copy link
Member

Summary

Resolves #1929

It is possible that Chain['transactionService' | 'vpcTransactionService'] have trailing slashes, which breaks requests to the Transaction Service as we expect none to be present.

This refines the incoming values, removing the trailing slash if present.

Changes

  • Remove trailing slashes from Chain['transactionService' | 'vpcTransactionService'] if present
  • Add appropriate test coverage

@iamacook iamacook self-assigned this Sep 16, 2024
@iamacook iamacook requested a review from a team as a code owner September 16, 2024 13:52
@coveralls
Copy link

coveralls commented Sep 16, 2024

Pull Request Test Coverage Report for Build 10898745054

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 90.658%

Totals Coverage Status
Change from base Build 10879486809: -0.02%
Covered Lines: 8354
Relevant Lines: 8840

💛 - Coveralls

Copy link
Contributor

@PooyaRaki PooyaRaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamacook iamacook merged commit f8bd635 into main Sep 17, 2024
18 checks passed
@iamacook iamacook deleted the chain-transaction-service-slash branch September 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Transaction Service URLs have no trailing slash
3 participants