Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Safe logo in Swagger #566

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Use Safe logo in Swagger #566

merged 1 commit into from
Jul 19, 2023

Conversation

fmrsabino
Copy link
Contributor

@fmrsabino fmrsabino commented Jul 14, 2023

Closes #535

  • Displays the Safe logo in the top bar of the Swagger interface
  • Displays the Safe logo as the favicon for the website
  • Integrates ServeStaticModule in order to publish static content to the clients.
  • Static content is stored under /assets and is available under the root path of the application (once deployed).

@fmrsabino fmrsabino self-assigned this Jul 14, 2023
@coveralls
Copy link

coveralls commented Jul 14, 2023

Pull Request Test Coverage Report for Build 5599349217

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 92.527%

Totals Coverage Status
Change from base Build 5585849028: 0.06%
Covered Lines: 4318
Relevant Lines: 4569

💛 - Coveralls

@fmrsabino fmrsabino force-pushed the add-swagger-logo branch 3 times, most recently from f025064 to 3a9c381 Compare July 19, 2023 12:35
- Displays the Safe logo in the top bar of the Swagger interface
- Displays the Safe logo as the favicon for the website
- Integrates `ServeStaticModule` in order to publish static content to the clients.
- Static content is stored under `/assets` and is available under the root path of the application (once deployed).
@fmrsabino fmrsabino marked this pull request as ready for review July 19, 2023 12:52
@fmrsabino fmrsabino requested a review from a team as a code owner July 19, 2023 12:52
Copy link
Member

@hectorgomezv hectorgomezv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@fmrsabino fmrsabino merged commit 491dc42 into main Jul 19, 2023
16 checks passed
@fmrsabino fmrsabino deleted the add-swagger-logo branch July 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Safe logo to Swagger interface
3 participants