Fix typing and defaults on SafeTx

safe-global · Feb 7, 2022 · 3978e92 · 3978e92
1 parent 5eaaa5d
commit 3978e92
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/gnosis/safe/multi_send.py b/gnosis/safe/multi_send.py
@@ -177,6 +177,7 @@ def __init__(self, address: str, ethereum_client: EthereumClient):
     def from_bytes(cls, encoded_multisend_txs: Union[str, bytes]) -> List[MultiSendTx]:
         """
         Decodes one or more multisend transactions from `bytes transactions` (Abi decoded)
+
         :param encoded_multisend_txs:
         :return: List of MultiSendTxs
         """
@@ -206,6 +207,7 @@ def from_transaction_data(
     ) -> List[MultiSendTx]:
         """
         Decodes multisend transactions from transaction data (ABI encoded with selector)
+
         :return:
         """
         try:
@@ -222,6 +224,7 @@ def deploy_contract(
     ) -> EthereumTxSent:
         """
         Deploy proxy factory contract
+
         :param ethereum_client:
         :param deployer_account: Ethereum Account
         :return: deployed contract address
@@ -249,6 +252,7 @@ def get_contract(self):
     def build_tx_data(self, multi_send_txs: List[MultiSendTx]) -> bytes:
         """
         Txs don't need to be valid to get through
+
         :param multi_send_txs:
         :param sender:
         :return:

diff --git a/gnosis/safe/safe_tx.py b/gnosis/safe/safe_tx.py
@@ -81,16 +81,16 @@ def __init__(
         self,
         ethereum_client: EthereumClient,
         safe_address: str,
-        to: str,
+        to: Optional[str],
         value: int,
         data: bytes,
         operation: int,
         safe_tx_gas: int,
         base_gas: int,
         gas_price: int,
-        gas_token: str,
-        refund_receiver: str,
-        signatures: bytes = b"",
+        gas_token: Optional[str],
+        refund_receiver: Optional[str],
+        signatures: Optional[bytes] = None,
         safe_nonce: Optional[int] = None,
         safe_version: str = None,
         chain_id: Optional[int] = None,
@@ -115,7 +115,6 @@ def __init__(
         it will be retrieved from the provided ethereum_client
         """
 
-        assert isinstance(signatures, bytes), "Signatures must be bytes"
         self.ethereum_client = ethereum_client
         self.safe_address = safe_address
         self.to = to or NULL_ADDRESS
@@ -127,7 +126,7 @@ def __init__(
         self.gas_price = gas_price
         self.gas_token = gas_token or NULL_ADDRESS
         self.refund_receiver = refund_receiver or NULL_ADDRESS
-        self.signatures = signatures
+        self.signatures = signatures or b""
         self._safe_nonce = safe_nonce
         self._safe_version = safe_version
         self._chain_id = chain_id