Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EthereumClientProvider #1209

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Remove EthereumClientProvider #1209

merged 1 commit into from
Jul 10, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jul 9, 2024

  • That solution was very hacky, typing was not working correctly
  • Create a new get_auto_ethereum_client
  • Refactor code to use the new method
  • Closes Remove EthereumClientProvider #1205

- That solution was very hacky, typing was not working correctly
- Create a new `get_auto_ethereum_client`
- Refactor code to use the new method
@Uxio0 Uxio0 requested a review from a team as a code owner July 9, 2024 11:28
@Uxio0 Uxio0 added the breaking_change Breaking change label Jul 9, 2024
@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9856192779

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 93.587%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gnosis/eth/ethereum_client.py 8 10 80.0%
Totals Coverage Status
Change from base Build 9854567128: 0.03%
Covered Lines: 8230
Relevant Lines: 8794

💛 - Coveralls

Uxio0 added a commit to safe-global/safe-transaction-service that referenced this pull request Jul 9, 2024
Uxio0 added a commit to safe-global/safe-transaction-service that referenced this pull request Jul 9, 2024
except ImportError:
from functools import lru_cache

cache = lru_cache(maxsize=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@Uxio0 Uxio0 merged commit 071f960 into main Jul 10, 2024
7 checks passed
@Uxio0 Uxio0 deleted the remove-ethereum-provider branch July 10, 2024 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking_change Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EthereumClientProvider
3 participants