Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create EthereumAddressFastBinaryField #1211

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Create EthereumAddressFastBinaryField #1211

merged 1 commit into from
Jul 12, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jul 12, 2024 •
edited
Loading

@Uxio0 Uxio0 requested a review from a team as a code owner July 12, 2024 11:51
@Uxio0 Uxio0 changed the title optimize ethereumfield model Create EthereumAddressFastBinaryField Jul 12, 2024
@coveralls
Copy link

coveralls commented Jul 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9908934473

Details

  • 57 of 64 (89.06%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 93.552%
Changes Missing Coverage Covered Lines Changed/Added Lines %
gnosis/eth/django/validators.py 6 9 66.67%
gnosis/eth/django/models.py 14 18 77.78%
Totals Coverage Status
Change from base Build 9908829022: -0.07%
Covered Lines: 8140
Relevant Lines: 8701
💛 - Coveralls

@Uxio0 Uxio0 force-pushed the optimize-ethereumfield-model branch from 3793e96 to 0190c35 Compare July 12, 2024 11:59
@Uxio0 Uxio0 force-pushed the optimize-ethereumfield-model branch from 0190c35 to 80e1441 Compare July 12, 2024 12:37
@Uxio0 Uxio0 force-pushed the optimize-ethereumfield-model branch from 80e1441 to 1d3b035 Compare July 12, 2024 13:46
@Uxio0
Implement a new EthereumAddressFastBinaryField
a180fd9 
- Faster than `EthereumAddressBinaryField` as it does not involve EIP55 checksums
- Depends on #835 to be merged first
@Uxio0 Uxio0 force-pushed the optimize-ethereumfield-model branch from 1d3b035 to a180fd9 Compare July 12, 2024 13:47
@Uxio0 Uxio0 merged commit 0c9292b into main Jul 12, 2024
7 checks passed
@Uxio0 Uxio0 deleted the optimize-ethereumfield-model branch July 12, 2024 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @falvaradorodriguez