Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle exception for get_signing_address to get previous behaviour #190

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Handle exception for get_signing_address to get previous behaviour #190

merged 1 commit into from
Feb 14, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Feb 9, 2022

  • Before deprecating pyethereum NULL_ADDRESS was returned instead of raising an exception

@Uxio0
Handle exception for get_signing_address to get previous behaviour
92b2d67 
- Before deprecating `pyethereum` NULL_ADDRESS was returned instead of raising an exception
@Uxio0 Uxio0 requested a review from fmrsabino February 9, 2022 16:38
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.384% when pulling 92b2d67 on fix-get-signing-address into 44e2c65 on master.

@Uxio0 Uxio0 merged commit 39d6fd0 into master Feb 14, 2022
@Uxio0 Uxio0 deleted the fix-get-signing-address branch February 14, 2022 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @fmrsabino