Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arbitrum Goerli 421613 #406

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Add Arbitrum Goerli 421613 #406

merged 1 commit into from
Dec 7, 2022

Conversation

gzeoneth
Copy link
Contributor

@gzeoneth gzeoneth commented Dec 5, 2022

No description provided.

@gzeoneth gzeoneth requested a review from a team as a code owner December 5, 2022 17:20
@coveralls
Copy link

coveralls commented Dec 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3622413514

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 83.927%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/oracles/oracles.py 4 50.46%
gnosis/eth/oracles/superfluid.py 9 55.0%
Totals Coverage Status
Change from base Build 3618436242: -0.3%
Covered Lines: 3274
Relevant Lines: 3901
💛 - Coveralls

@gzeoneth gzeoneth mentioned this pull request Dec 5, 2022
Merged
moisses89
moisses89 requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the blockscout explorer here?
There is one blockexplorer listed https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-421613.json

moisses89
moisses89 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blockexplorer is not mandatory, only a suggestion :)

@moisses89 moisses89 merged commit a6a9dfb into safe-global:master Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gzeoneth @coveralls @Uxio0 @moisses89