Fix wrong domain separator for contract versions below 1.3.0 #422
Conversation
moisses89
requested review from
fmrsabino,
Uxio0 and
hectorgomezv
and removed request for
a team
Pull Request Test Coverage Report for Build 3900620694
💛 - Coveralls |
gnosis/safe/safe.py
Outdated
| self.ethereum_client.get_chain_id(), | ||
| self.address, | ||
| ], | ||
| version = self.contract.functions.VERSION().call() |
There was a problem hiding this comment.
I am following the implementation of domain_separator which is computed instead of calling the contract.
I'm not sure why, but maybe this was implemented at this way to avoid asking the blockchain one more time.
If this were the reason, then this implementation should be changed to create a @cached_property of the contract version or perhaps call domain_separator directly to the blockchain instead of requesting the version once more.
There was a problem hiding this comment.
I'd say that the library was just assuming 1.3.0 for the domain separator. Therefore, it wouldn't perform any RPC calls given that assumption.
gnosis/safe/safe.py
Outdated
| self.ethereum_client.get_chain_id(), | ||
| self.address, | ||
| ], | ||
| version = self.contract.functions.VERSION().call() |
There was a problem hiding this comment.
I'd say that the library was just assuming 1.3.0 for the domain separator. Therefore, it wouldn't perform any RPC calls given that assumption.
Closes #421
domainSeparatorcalculation for contract version 1.1.1