Bump postgres version #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
requested review from
fmrsabino,
Uxio0 and
hectorgomezv
and removed request for
a team
Pull Request Test Coverage Report for Build 3904382433
💛 - Coveralls |
fmrsabino
reviewed
Jan 12, 2023
docker-compose.yml
Outdated
| @@ -2,7 +2,7 @@ version: '3.5' | |||
|
|
|||
| services: | |||
| db: | |||
| image: postgres:10-alpine | |||
| image: postgres:13-alpine | |||
There was a problem hiding this comment.
Why not use the latest stable? postgres:15-alpine
There was a problem hiding this comment.
I only tried with the same version that is for github actions, I'm happy using the last version of postgres for locally tests. I just updated to postgres:15-alpine.
There was a problem hiding this comment.
I tested it locally also.
There was a problem hiding this comment.
We were using postgres:13 just because is the last version supported by AWS, but postgres:15 should do it
moisses89
force-pushed
the
bump_postgres13
branch
from
15e1553
to
7123cf0
Compare
fmrsabino
approved these changes
Jan 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current django version don't support
postgresql-10:FAILED gnosis/safe/tests/api/test_transaction_service_api.py::TestTransactionServiceAPI::test_get_balances - django.db.utils.NotSupportedError: PostgreSQL 11 or later is required (found 10.23).The version 13 was chosen to be aligned with our github actions https://github.com/safe-global/safe-eth-py/blob/master/.github/workflows/python.yml#L41