Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support int formatted as string for eip712_encode #437

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add support int formatted as string for eip712_encode #437

merged 1 commit into from
Jan 16, 2023

Conversation

moisses89
Copy link
Member

Description

This PR is taking account the following review #427 (review)

Changes

  • Support also int formatted as string
  • Some minor changes

@moisses89 moisses89 requested a review from a team as a code owner January 16, 2023 11:48
@moisses89 moisses89 requested review from fmrsabino, Uxio0 and hectorgomezv and removed request for a team January 16, 2023 11:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3930057819

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 90.279%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/ethereum_client.py 1 86.74%
Totals Coverage Status
Change from base Build 3929910771: -0.03%
Covered Lines: 3529
Relevant Lines: 3909
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3930057819

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 90.279%
Totals Coverage Status
Change from base Build 3929910771: -0.03%
Covered Lines: 3529
Relevant Lines: 3909
💛 - Coveralls

@moisses89 moisses89 mentioned this pull request Jan 16, 2023
Merged
@moisses89 moisses89 merged commit fc0ac41 into master Jan 16, 2023
@moisses89 moisses89 deleted the minor_changes_pr_427 branch January 16, 2023 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moisses89 @coveralls @Uxio0