Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chains on EthereumNetwork #452

Merged
merged 12 commits into from
Feb 3, 2023
Merged

Update Chains on EthereumNetwork #452

merged 12 commits into from
Feb 3, 2023

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Feb 1, 2023 •
edited
Loading

Purpose

The purpose of this PR is update the EthereumNetwork with the official name of each chain following the names indicated in https://github.com/ethereum-lists/chains/tree/master/_data/chains
This PR also add several chains that wasn't included before.
EthereumNetwork now is sorted by chainId.

@moisses89 moisses89 requested a review from a team as a code owner February 1, 2023 16:54
@moisses89 moisses89 requested review from fmrsabino, Uxio0 and hectorgomezv and removed request for a team February 1, 2023 16:54
@coveralls
Copy link

coveralls commented Feb 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4084079118

  • 641 of 641 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.6%) to 90.54%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/ethereum_client.py 1 86.74%
gnosis/safe/safe.py 1 88.43%
gnosis/util/util.py 3 66.67%
Totals Coverage Status
Change from base Build 4073775364: 0.6%
Covered Lines: 3771
Relevant Lines: 4165
💛 - Coveralls

@moisses89 moisses89 changed the title Update EthereumNetwork enum Update Chains on EthereumNetwork Feb 1, 2023
@Uxio0 Uxio0 added the breaking_change Breaking change label Feb 2, 2023
@moisses89 moisses89 mentioned this pull request Feb 2, 2023
Merged
@Uxio0 Uxio0 merged commit c189994 into master Feb 3, 2023
@Uxio0 Uxio0 deleted the update_chains branch February 3, 2023 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
breaking_change Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moisses89 @coveralls @Uxio0