Don't log price oracle failures #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not relevant if a price oracle cannot retrieve the price, as there's already an exception returned for that - Update price oracle logs from `WARNING` to `DEBUG`
Uxio0
requested review from
fmrsabino,
moisses89 and
hectorgomezv
and removed request for
a team
Pull Request Test Coverage Report for Build 4103225065
💛 - Coveralls |
moisses89
reviewed
Feb 6, 2023
| error_message = f"Cannot get decimals for token={token_address}" | ||
| logger.warning(error_message) | ||
| raise CannotGetPriceFromOracle(error_message) from e | ||
| message = f"Cannot get decimals for token={token_address}" |
There was a problem hiding this comment.
Is this related with the price? I mean, ERC20 should have decimals method.
There was a problem hiding this comment.
Yes, but when we are calculating the price we use anything that looks like an ERC20, so I wouldn't log this kind of errors. This method is only used from oracles
moisses89
approved these changes
Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not relevant if a price oracle cannot retrieve the price, as there's already an exception returned for that
WARNINGtoDEBUG