Fix EIP712 encoding

[Uxio0]

• Fix empty arrays
• Fix arrays with repeating elements

[mmv08]

🔝

[coveralls]

Pull Request Test Coverage Report for Build 4142981802

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage remained the same at 90.634%

---

Files with Coverage Reduction	New Missed Lines	%
gnosis/eth/ethereum_client.py	1	86.74%

Totals
Change from base Build 4112569321:	0.0%
Covered Lines:	3774
Relevant Lines:	4164

---

💛 - Coveralls

[Uxio0]

Using the following node script to validate the hashes:

const { ethers } = require('ethers')

const typedData = {
    "types": {
        "Nested": [
            {
                "name": "nestedString",
                "type": "string"
            },
            {
                "name": "nestedAddress",
                "type": "address"
            },
            {
                "name": "nestedUint256",
                "type": "uint256"
            },
            {
                "name": "nestedUint32",
                "type": "uint32"
            },
            {
                "name": "nestedBytes32",
                "type": "bytes32"
            },
            {
                "name": "nestedBoolean",
                "type": "bool"
            }
        ],
        "Example": [
            {
                "name": "testString",
                "type": "string"
            },
            {
                "name": "testAddress",
                "type": "address"
            },
            {
                "name": "testUint256",
                "type": "uint256"
            },
            {
                "name": "testUint32",
                "type": "uint32"
            },
            {
                "name": "testBytes32",
                "type": "bytes32"
            },
            {
                "name": "testBoolean",
                "type": "bool"
            },
            {
                "name": "testNested",
                "type": "Nested"
            },
            {
                "name": "testNestedArray",
                "type": "Nested[]"
            }
        ],
        "EIP712Domain": [
            {
                "name": "name",
                "type": "string"
            },
            {
                "name": "version",
                "type": "string"
            },
            {
                "name": "chainId",
                "type": "uint256"
            },
            {
                "name": "verifyingContract",
                "type": "address"
            }
        ]
    },
    "domain": {
        "name": "EIP-1271 Example DApp",
        "version": "1.0",
        "chainId": "5",
        "verifyingContract": "0xaecdfd3a19f777f0c03e6bf99aafb59937d6467b"
    },
    "primaryType": "Example",
    "message": {
        "testString": "Hello Deeeeeemo",
        "testAddress": "0xaecdfd3a19f777f0c03e6bf99aafb59937d6467b",
        "testUint256": "115792089237316195423570985008687907853269984665640564039457584007908834671663",
        "testUint32": "123",
        "testBytes32": "0x00000000000000000000000000000000000000000000000000000000deadbeef",
        "testBoolean": true,
        "testNested": {
            "nestedString": "Hello Deeeeeemo",
            "nestedAddress": "0x0000000000000000000000000000000000000002",
            "nestedUint256": "0",
            "nestedUint32": "1",
            "nestedBytes32": "0x000000000000000000000000000000000000000000000000000000000000da7a",
            "nestedBoolean": false
        },
        "testNestedArray": [
            {
                "nestedString": "Hello Deeeeeemo",
                "nestedAddress": "0x0000000000000000000000000000000000000002",
                "nestedUint256": "0",
                "nestedUint32": "1",
                "nestedBytes32": "0x000000000000000000000000000000000000000000000000000000000000da7a",
                "nestedBoolean": false
            },
            {
                "nestedString": "Hello Deeeeeemo",
                "nestedAddress": "0x0000000000000000000000000000000000000002",
                "nestedUint256": "0",
                "nestedUint32": "1",
                "nestedBytes32": "0x000000000000000000000000000000000000000000000000000000000000da7a",
                "nestedBoolean": false
            }
        ]
    }
}

const { EIP712Domain: _, ...types } = typedData.types
console.log(ethers.utils._TypedDataEncoder.hash(typedData.domain, types, typedData.message))

[moisses89]

Looks good only a suggestion :)

[moisses89]

I suggest to check if value exists before to get the type_value_pairs you can do something like:

     if value:
          parsed_type = typ[: typ.rindex("[")]
          type_value_pairs = [_encode_field(name, parsed_type, v) for v in value]
          data_types, data_hashes = zip(*type_value_pairs)
      else: 
          data_types, data_hashes = [], []

[Uxio0]

Good suggestion, more optimal!

[Uxio0]

Done

[moisses89]

🚀