Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more E2E trace_block tests for Erigon #463

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Add more E2E trace_block tests for Erigon #463

merged 1 commit into from
Feb 15, 2023

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Feb 15, 2023 •
edited
Loading

  • We were missing some E2E for previously problematic blocks (15630274)

@Uxio0
Add more E2E trace_block tests for Erigon
dc19a0a 
- We were missing some E2E for previously problematic blocks
@Uxio0 Uxio0 requested a review from a team as a code owner February 15, 2023 10:12
@Uxio0 Uxio0 requested review from fmrsabino, moisses89 and hectorgomezv and removed request for a team February 15, 2023 10:12
@coveralls
Copy link

coveralls commented Feb 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4182781257

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 90.658%
Totals Coverage Status
Change from base Build 4162229129: 0.02%
Covered Lines: 3775
Relevant Lines: 4164
💛 - Coveralls

moisses89
moisses89 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you add in the description what is adding this block or what test was missing?

@Uxio0 Uxio0 merged commit 61b958f into master Feb 15, 2023
@Uxio0 Uxio0 deleted the add-more-tracing-tests branch February 15, 2023 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
@Uxio0
Copy link
Member Author

Uxio0 commented Feb 15, 2023

Looks good to me, could you add in the description what is adding this block or what test was missing?

Oh, I see with code formatting is not clear, I added one more block that it was problematic before 15630274

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @moisses89