Allow configuration of internal parameters #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
reviewed
May 3, 2024
gnosis/safe/api/base_api.py
Outdated
| @@ -24,7 +25,7 @@ def __init__( | |||
| network: EthereumNetwork, | |||
| ethereum_client: Optional[EthereumClient] = None, | |||
| base_url: Optional[str] = None, | |||
| request_timeout: int = 10, | |||
| request_timeout: int = int(os.environ.get("SAFE_BASE_API_REQUEST_TIMEOUT", 10)), | |||
There was a problem hiding this comment.
I think that would be better define this timeout in the childs, intead here.
I mean something like SAFE_TRANSACTION_SERVICE_REQUEST_TIMEOUT, and the same for the relay, but not sure if will be continued.
There was a problem hiding this comment.
Relay is discontinued, we should remove it. But I agree on defining this variable for every child
There was a problem hiding this comment.
Added in TransactionServiceApi. RelayServiceApi will be removed in this PR.
moisses89
approved these changes
May 3, 2024
Uxio0
approved these changes
May 3, 2024
|
@falvaradorodriguez Could you add documentation for this when it's merged? |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #784
To be considered:
Some of this task was done in these previous PRs:
Make EthereumClient timeouts configurable via envvars #209
Make Django dependency optional #641
I have checked some timeouts that were hardcoded, I would like to check with the team what other settings are missing.