Fixed and More Consistent Pragmas #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the pragmas in the passkeys contract to be:
1. More consistent: we use `^0.8.20` everywhere for "non-top-level"
contracts. The version was chosen as this it the first version that
supports all of the compiler features that we make use of. Notably,
we have `@custom:` NatSpec items which are only officially supported
as of v0.8.20. The choice to use floating pragmas here is to make
using these support contracts easier across other projects (namely,
the `WebAuthn` and `P256` libraries are useful outside of this
project).
2. Use fixed pragmas for "top-level" contracts that we deploy:
- `SafeWebAuthnProxyFactory`
- `SafeWebAuthnSharedSigner`
- `FCLP256Verifier`
I am aware that Solidity v0.8.20 doesn't play nice with chains like BNB
by default, however this can be worked around by explicitly by setting
the EVM version target (as we do in this project) and do not believe
this is an issue.
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
mmv08
approved these changes
Jul 5, 2024
Pull Request Test Coverage Report for Build 9806169607Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9806169608Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9806232134Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hats-finance#17
This PR changes the pragmas in the passkeys contract to be:
^0.8.20everywhere for "non-top-level" contracts. The version was chosen as this it the first version that supports all of the compiler features that we make use of. Notably, we have@custom:NatSpec items which are only officially supported as of v0.8.20 (incidentally, this is the same version used by OpenZeppelin contracts for similar reason: source). The choice to use floating pragmas here is to make using these support contracts easier across other projects (namely, theWebAuthnandP256libraries are useful outside of this project). Furthermore, we use^versions so that breaking changes introduced in a potential Solidity v0.9 would not affect the security and integrity of the contract code.SafeWebAuthnProxyFactorySafeWebAuthnSharedSignerFCLP256VerifierI am aware that Solidity v0.8.20 doesn't play nice with chains like BNB by default, however this can be worked around by explicitly by setting the EVM version target (as we do in this project) and do not believe this is an issue.