Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-1271 is implemented with wrong visibility modifier #166

Closed
3esmit opened this issue Jan 9, 2020 · 1 comment
Closed

EIP-1271 is implemented with wrong visibility modifier #166

3esmit opened this issue Jan 9, 2020 · 1 comment

Comments

@3esmit
Copy link

3esmit commented Jan 9, 2020 •
edited
Loading

The interface is market as external (executable), when it should be public view.

https://github.com/gnosis/safe-contracts/blob/892448e93f6203b530630f20de45d8a55fde7463/contracts/GnosisSafe.sol#L320-L323

The interface contract is correct, according to http://eips.ethereum.org/EIPS/eip-1271

https://github.com/gnosis/safe-contracts/blob/892448e93f6203b530630f20de45d8a55fde7463/contracts/interfaces/ISignatureValidator.sol#L19-L24
@3esmit 3esmit mentioned this issue Jan 9, 2020
Closed
1 task
@rmeissner rmeissner added the future Features for next major contract version label Apr 19, 2020
@rmeissner
Copy link
Member

see #223

@rmeissner rmeissner removed the future Features for next major contract version label Jul 9, 2020
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#166 from gnosis/fix-safe-version
f0d9404 
Fix safe version and refactor safe deployments functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix ERC-1271 interface status-im/safe-contracts
2 participants
@3esmit @rmeissner