Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support L2 Safes upgraded from non L2 Safes #1703

Closed
Uxio0 opened this issue Oct 13, 2023 · 2 comments
Closed

Support L2 Safes upgraded from non L2 Safes #1703

Uxio0 opened this issue Oct 13, 2023 · 2 comments
Assignees
@Uxio0
Labels
enhancement New feature or request

Comments

@Uxio0
Copy link
Member

Uxio0 commented Oct 13, 2023 •
edited
Loading

What is needed?

Support L2 Safes upgraded from non L2 Safes

Background

  • When a non L2 Safe is replayed in a L2 network, indexer cannot pick it as setup event and initial state of the Safe is missed.
  • We should find a way to support that kind of Safes in the UI.

Related issues

Example
@Uxio0 Uxio0 added the enhancement New feature or request label Oct 13, 2023
@Uxio0 Uxio0 self-assigned this Oct 16, 2023
Uxio0 added a commit to safe-global/safe-smart-account that referenced this issue Oct 19, 2023
@Uxio0
Add contract to migrate a Safe from not L2 to L2
196557e 
- Related to safe-global/safe-transaction-service#1703
@Uxio0 Uxio0 mentioned this issue Oct 19, 2023
Merged
Uxio0 added a commit to safe-global/safe-smart-account that referenced this issue Oct 24, 2023
@Uxio0
Add contract to migrate a Safe from not L2 to L2
07c8a93 
- Related to safe-global/safe-transaction-service#1703
@moisses89 moisses89 mentioned this issue Oct 30, 2023
Closed
Uxio0 added a commit to safe-global/safe-smart-account that referenced this issue Oct 31, 2023
@Uxio0
Add contract to migrate a Safe from not L2 to L2 (#685)
482332f 
* Add contract to migrate a Safe from not L2 to L2
* Related to safe-global/safe-transaction-service#1703
@JagoFigueroa
Copy link

Looks good to me, I was able to transact on a upgraded safe without any issues. Here are a few transactions 😄

Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
@Uxio0
Add contract to migrate a Safe from not L2 to L2 (safe-global#685)
53b3e7a 
* Add contract to migrate a Safe from not L2 to L2
* Related to safe-global/safe-transaction-service#1703
@Uxio0 Uxio0 mentioned this issue Nov 6, 2023
Merged
@Uxio0
Copy link
Member Author

Uxio0 commented Apr 12, 2024

Working out of the box when using the provided contract on: safe-global/safe-smart-account#685

@Uxio0 Uxio0 closed this as completed Apr 12, 2024
mmv08 pushed a commit to safe-global/safe-smart-account that referenced this issue Jul 22, 2024
@Uxio0 @mmv08
Add contract to migrate a Safe from not L2 to L2 (#685)
8e28148 
* Add contract to migrate a Safe from not L2 to L2
* Related to safe-global/safe-transaction-service#1703
dodger213 added a commit to dodger213/safe-smart-contract that referenced this issue Aug 18, 2024
@dodger213
Add contract to migrate a Safe from not L2 to L2
828bf65 
- Related to safe-global/safe-transaction-service#1703
dodger213 added a commit to dodger213/safe-smart-contract that referenced this issue Aug 18, 2024
@dodger213
Add contract to migrate a Safe from not L2 to L2 (#685)
d877f90 
* Add contract to migrate a Safe from not L2 to L2
* Related to safe-global/safe-transaction-service#1703
BinaryBard-0604 added a commit to BinaryBard-0604/safe-smart-contract that referenced this issue Sep 23, 2024
@BinaryBard-0604
Add contract to migrate a Safe from not L2 to L2
e476df3 
- Related to safe-global/safe-transaction-service#1703
BinaryBard-0604 added a commit to BinaryBard-0604/safe-smart-contract that referenced this issue Sep 23, 2024
@BinaryBard-0604
Add contract to migrate a Safe from not L2 to L2 (#685)
ab30119 
* Add contract to migrate a Safe from not L2 to L2
* Related to safe-global/safe-transaction-service#1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Uxio0 @JagoFigueroa