Install deployment dependencies when circle:deps is executed #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What Install deployment dependencies when circle:deps is executed ### Why So that we don't have to remember to _always_ do it https://github.com/sagansystems/remail/pull/4/files ### Who
|
pointed the "circle" tag to this commit - and ran supernova build - it installed gettext fine |
darend
reviewed
Nov 21, 2017
| @@ -78,3 +78,11 @@ circle\:run-job-kubernetes: | |||
| echo "INFO: Running $(JOB_KUBERNETES_APP):$(IMAGE_TAG)"; \ | |||
| $(MAKEFILE_DIR)/bin/circle-do-exclusively.sh --branch $(CIRCLE_BRANCH) $(SELF) kubernetes:run-job kubernetes:job-logs KUBERNETES_APP=$(JOB_KUBERNETES_APP); \ | |||
| fi | |||
|
|
|||
| ## Install deployment dependencies | |||
| install-deployment-dependencies: | |||
There was a problem hiding this comment.
Using this approach of a mac and linux target would be beneficial as it allows testing of the makefile locally
https://github.com/sagansystems/cloud-platform/blob/8.0/conf/tf/Makefile#L14-L24
|
Declining per golang/go#18981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Install deployment dependencies when circle:deps is executed
Why
So that we don't have to remember to always do it
https://github.com/sagansystems/remail/pull/4/files
Who
@darend