Skip to content

Commit

Permalink
Test split CRLF
Browse files Browse the repository at this point in the history
- Add a test for CRLF split between two buffers (a.k.a issue C2FO#150) to
  specify the expected behavior
- Mark it `skip` pending implementation
  • Loading branch information
Alex Tsibulya committed Sep 22, 2016
1 parent 16b7a8e commit 43c6d6a
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions test/parser.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ it.describe("fast-csv parser", function (it) {
});

it.should("parse a block of CSV text with a trailing delimiter", function () {
var data = "first_name,last_name,email_address,empty\nFirst1,Last1,email1@email.com,\n";
var data = "first_name,last_name,email_address,empty\rFirst1,Last1,email1@email.com,\r";
var myParser = parser({delimiter: ","});
assert.deepEqual(myParser(data, false), {
"line": "", "rows": [
Expand All @@ -330,7 +330,7 @@ it.describe("fast-csv parser", function (it) {
});

it.should("parse a block of CSV text with a trailing delimiter followed by a space", function() {
var data = "first_name,last_name,email_address,empty\nFirst1,Last1,email1@email.com, \n";
var data = "first_name,last_name,email_address,empty\nFirst1,Last1,email1@email.com, \r";
var myParser = parser({ delimiter: "," });
assert.deepEqual(myParser(data, false), {
"line": "", "rows": [
Expand All @@ -341,7 +341,7 @@ it.describe("fast-csv parser", function (it) {
});

it.should("parse a block of Space Separated Value text with a trailing delimiter", function() {
var data = "first_name last_name email_address empty\nFirst1 Last1 email1@email.com \n";
var data = "first_name last_name email_address empty\rFirst1 Last1 email1@email.com \r";
var myParser = parser({ delimiter: " " });
assert.deepEqual(myParser(data, false), {
"line": "", "rows": [
Expand Down Expand Up @@ -614,6 +614,16 @@ it.describe("fast-csv parser", function (it) {
});
});

it.skip("not parse a row if a new line is incomplete and there is more data", function () {
var data = "first_name,last_name,email_address\r";
var myParser = parser({delimiter: ","});
var parsedData = myParser(data, true);
assert.deepEqual(parsedData, {
"line": "first_name,last_name,email_address\r",
"rows": []
});
});

it.should("not parse a row if there is a trailing delimiter and there is more data", function () {
var data = "first_name,last_name,email_address,";
var myParser = parser({delimiter: ","});
Expand Down

0 comments on commit 43c6d6a

Please sign in to comment.