Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error type updates #258

Merged
merged 18 commits into from
Nov 24, 2020
Merged

Error type updates #258

merged 18 commits into from
Nov 24, 2020

Conversation

sagebind
Copy link
Owner

@sagebind sagebind commented Nov 18, 2020

Update isahc::Error to support taking new variants in a backwards-compatible way, as well as hold more error sources when an error is caused by another.

Note that this is the first 1.0 breaking change to land on master. If 0.9 needs a patch fix in the future, we'll have to make a 0.9.x branch for it.

Fixes #182.

@sagebind sagebind added the enhancement Make a feature better label Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #258 (fed6133) into master (e7284e3) will decrease coverage by 0.24%.
The diff coverage is 47.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   72.11%   71.86%   -0.25%     
==========================================
  Files          49       49              
  Lines        2460     2513      +53     
==========================================
+ Hits         1774     1806      +32     
- Misses        686      707      +21     
Impacted Files Coverage Δ
src/body.rs 75.38% <ø> (ø)
src/config/mod.rs 56.19% <ø> (ø)
src/interceptor/mod.rs 0.00% <ø> (ø)
src/lib.rs 75.00% <ø> (ø)
src/error.rs 40.57% <40.87%> (+11.66%) ⬆️
src/client.rs 69.66% <55.55%> (-0.04%) ⬇️
src/agent.rs 68.58% <100.00%> (ø)
src/handler.rs 71.68% <100.00%> (ø)
src/interceptor/context.rs 75.00% <100.00%> (ø)
src/interceptor/obj.rs 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7284e3...fed6133. Read the comment docs.

@sagebind sagebind marked this pull request as ready for review November 24, 2020 01:45
@sagebind sagebind merged commit 5212209 into master Nov 24, 2020
@sagebind sagebind deleted the error-type-updates branch November 24, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make a feature better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error type updates
1 participant