Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting low speed timeouts via Configurable #316

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Allow setting low speed timeouts via Configurable #316

merged 1 commit into from
Mar 31, 2021

Conversation

MoSal
Copy link
Contributor

@MoSal MoSal commented Mar 29, 2021

Expose libcurl's low speed timeout functionality by adding
a low_speed_timeout() method to Configurable.

 Expose libcurl's low speed timeout functionality by adding
 a `low_speed_timeout()` method to `Configurable`.

Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal MoSal requested a review from sagebind as a code owner March 29, 2021 18:17
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #316 (1aced2b) into master (2cd2f88) will decrease coverage by 0.11%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   75.37%   75.25%   -0.12%     
==========================================
  Files          57       57              
  Lines        2977     2983       +6     
==========================================
+ Hits         2244     2245       +1     
- Misses        733      738       +5     
Impacted Files Coverage Δ
src/config/mod.rs 70.24% <0.00%> (-1.79%) ⬇️
src/config/request.rs 74.64% <33.33%> (-1.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd2f88...1aced2b. Read the comment docs.

Copy link
Owner

@sagebind sagebind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@sagebind sagebind merged commit 3522593 into sagebind:master Mar 31, 2021
@sagebind
Copy link
Owner

sagebind commented Apr 7, 2021

This has been included in the 1.3.0 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants