Skip to content

Commit

Permalink
gh-36057: sage.arith: Update # needs
Browse files Browse the repository at this point in the history
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
- Part of: #29705
- Cherry-picked from: #35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #36057
Reported by: Matthias Köppe
Reviewer(s): David Coudert
  • Loading branch information
Release Manager committed Aug 26, 2023
2 parents e678d52 + 565fb2b commit 18ad7f8
Show file tree
Hide file tree
Showing 6 changed files with 660 additions and 609 deletions.
12 changes: 6 additions & 6 deletions src/sage/arith/functions.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -72,25 +72,25 @@ def lcm(a, b=None):
Make sure we try `\QQ` and not merely `\ZZ` (:trac:`13014`)::
sage: bool(lcm(2/5, 3/7) == lcm(SR(2/5), SR(3/7))) # optional - sage.symbolic
sage: bool(lcm(2/5, 3/7) == lcm(SR(2/5), SR(3/7))) # needs sage.symbolic
True
Make sure that the lcm of Expressions stays symbolic::
sage: parent(lcm(2, 4))
Integer Ring
sage: parent(lcm(SR(2), 4)) # optional - sage.symbolic
sage: parent(lcm(SR(2), 4)) # needs sage.symbolic
Symbolic Ring
sage: parent(lcm(2, SR(4))) # optional - sage.symbolic
sage: parent(lcm(2, SR(4))) # needs sage.symbolic
Symbolic Ring
sage: parent(lcm(SR(2), SR(4))) # optional - sage.symbolic
sage: parent(lcm(SR(2), SR(4))) # needs sage.symbolic
Symbolic Ring
Verify that objects without lcm methods but which can't be
coerced to `\ZZ` or `\QQ` raise an error::
sage: F.<x,y> = FreeMonoid(2) # optional - sage.groups
sage: lcm(x,y) # optional - sage.groups
sage: F.<x,y> = FreeMonoid(2) # needs sage.groups
sage: lcm(x,y) # needs sage.groups
Traceback (most recent call last):
...
TypeError: unable to find lcm of x and y
Expand Down
2 changes: 1 addition & 1 deletion src/sage/arith/long.pxd
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# sage.doctest: optional - sage.misc.cython
# sage.doctest: needs sage.misc.cython
r"""
Fast conversion of Python objects to C long
"""
Expand Down
Loading

0 comments on commit 18ad7f8

Please sign in to comment.