Skip to content

Commit

Permalink
Trac #33240: Demote linter errors about importing from "all" to warni…
Browse files Browse the repository at this point in the history
…ngs for now

The linter test about importing from "all"
currently fails for all tickets, thus hiding
new linting issues introduced in any ticket.

Until these imports are fixed,
demote the error to a warning.

URL: https://trac.sagemath.org/33240
Reported by: gh-tobiasdiez
Ticket author(s): Tobias Diez
Reviewer(s): Frédéric Chapoton
  • Loading branch information
Release Manager committed Jan 29, 2022
2 parents 4fc017f + e7f3ed8 commit 3320e6e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/.relint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,4 @@
Hint: namespace package. Type import_statements("SOME_IDENTIFIER") to find a more specific import.
pattern: 'from\s+sage[.](categories|misc|rings|combinat|graphs|interfaces|libs)[.]all\s+import'
filePattern: '.*[.](py|pyx)$'
error: false # Make this a warning instead of an error for now
2 changes: 1 addition & 1 deletion src/sage/rings/integer.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -7249,7 +7249,7 @@ def _check_global_dummy_Integer():
"""
Return true if the global dummy Integer is ok.
TEST::
TESTS::
sage: from sage.rings.integer import _check_global_dummy_Integer
sage: _check_global_dummy_Integer()
Expand Down

0 comments on commit 3320e6e

Please sign in to comment.