test that #20003 is fixed

sagemath · Jul 4, 2023 · 774de79 · 774de79
1 parent 5955a72
commit 774de79
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 32 deletions.
diff --git a/src/sage/rings/polynomial/polynomial_zmod_flint.pyx b/src/sage/rings/polynomial/polynomial_zmod_flint.pyx
@@ -659,6 +659,10 @@ cdef class Polynomial_zmod_flint(Polynomial_template):
             ...
             NotImplementedError: square free factorization of polynomials over rings with composite characteristic is not implemented
 
+        :trac:`20003`::
+
+            sage: (6*t+3).squarefree_decomposition()
+            (6) * (t + 4)
         """
         if not self.base_ring().is_field():
             raise NotImplementedError("square free factorization of polynomials over rings with composite characteristic is not implemented")

diff --git a/src/sage/schemes/plane_conics/con_rational_function_field.py b/src/sage/schemes/plane_conics/con_rational_function_field.py
@@ -195,38 +195,6 @@ def has_rational_point(self, point=False, algorithm='default',
             Fraction Field of Univariate Polynomial Ring in u over Rational
             Field with modulus v^2 - u^3 - 1
 
-        ``has_rational_point`` fails for some conics over function fields
-        over finite fields, due to :trac:`20003`::
-
-            sage: K.<t> = PolynomialRing(GF(7))                                         # optional - sage.rings.finite_rings
-            sage: C = Conic([5*t^2 + 4, t^2 + 3*t + 3, 6*t^2 + 3*t + 2,                 # optional - sage.rings.finite_rings
-            ....:            5*t^2 + 5, 4*t + 3, 4*t^2 + t + 5])
-            sage: C.has_rational_point()                                                # optional - sage.rings.finite_rings
-            Traceback (most recent call last):
-            ...
-            TypeError: self (=Scheme morphism:
-              From: Projective Conic Curve over Fraction Field of Univariate
-                    Polynomial Ring in t over Finite Field of size 7 defined by
-                    (-2*t^2 - 3)*x^2 + (-t^3 + 3*t^2 - 2*t - 2)/(t + 3)*y^2 + (-t^6 + 3*t^5 + t^3 - t^2 - t + 2)/(t^4 + t^3 - 3*t^2 + 3*t + 1)*z^2
-              To:   Projective Conic Curve over Fraction Field of Univariate
-                    Polynomial Ring in t over Finite Field of size 7 defined by
-                    (-2*t^2 - 3)*x^2 + (t^2 + 3*t + 3)*x*y + (-2*t^2 - 2)*y^2 + (-t^2 + 3*t + 2)*x*z + (-3*t + 3)*y*z + (-3*t^2 + t - 2)*z^2
-              Defn: Defined on coordinates by sending (x : y : z) to
-                    (x + (2*t - 2)/(t + 3)*y + (3*t^4 + 2*t^3 - 2*t^2 - 2*t + 3)/(t^4 + t^3 - 3*t^2 + 3*t + 1)*z
-                     : y + (-t^3 - t^2 + 3*t - 1)/(t^3 - 3*t^2 + 2*t + 2)*z : z))
-            domain must equal right (=Scheme morphism:
-              From: Projective Conic Curve over Fraction Field of Univariate
-                    Polynomial Ring in t over Finite Field of size 7 defined by
-                    (-2*t^3 - t^2 + 3*t + 3)*x^2 + (t - 3)*y^2 + (-t^7 + 2*t^5 + t^4 + 2*t^3 + 3*t^2 - t - 1)*z^2
-              To:   Projective Conic Curve over Fraction Field of Univariate
-                    Polynomial Ring in t over Finite Field of size 7 defined by
-                    -2/(t^3 - 3*t^2 + 2*t + 2)*x^2 + 1/(t^3 + 3*t^2 - 2*t + 1)*y^2 + (-t^6 + 3*t^5 + t^3 - t^2 - t + 2)/(t^9 - 2*t^8 + t^7 - t^6 + 3*t^5 - 3*t^3 + t^2 - 2*t + 3)*z^2
-              Defn: Defined on coordinates by sending (x : y : z) to
-                    ((t^3 - 3*t^2 + 2*t + 2)*x : (t^2 - 2)*y : (t^5 - 3*t^4 + t^2 + 3*t + 3)*z))
-            codomain
-
-
-
         TESTS::
 
             sage: K.<t> = FractionField(PolynomialRing(QQ, 't'))
@@ -247,6 +215,16 @@ def has_rational_point(self, point=False, algorithm='default',
             sage: C.has_rational_point(point = True) # long time (4 seconds)
             (True,
              ((-2/117*t^8 + 304/1053*t^7 + 40/117*t^6 - 1/27*t^5 - 110/351*t^4 - 2/195*t^3 + 11/351*t^2 + 1/117)/(t^4 + 2/39*t^3 + 4/117*t^2 + 2/39*t + 14/39) : -5/3*t^4 + 19*t^3 : 1))
+
+        ``has_rational_point`` used to fail for some conics over function fields
+        over finite fields, due to :trac:`20003`::
+
+            sage: K.<t> = PolynomialRing(GF(7))                                         # optional - sage.rings.finite_rings
+            sage: C = Conic([5*t^2 + 4, t^2 + 3*t + 3, 6*t^2 + 3*t + 2,                 # optional - sage.rings.finite_rings
+            ....:            5*t^2 + 5, 4*t + 3, 4*t^2 + t + 5])
+            sage: C.has_rational_point()                                                # optional - sage.rings.finite_rings
+            True
+
         """
         from .constructor import Conic