Skip to content

Commit

Permalink
Trac #30325: Optional package deformation fails to build: mpir.h not …
Browse files Browse the repository at this point in the history
…found

On `homebrew-macos-maximal`
(https://github.com/mkoeppe/sage/runs/959683064) - which uses gmp from
the system, not mpir...
{{{
 [deformation-d05941b.p0] error installing, exit status 1. End of log
file:
  [deformation-d05941b.p0]   /Users/runner/work/sage/sage/.tox/local-
homebrew-macos-maximal/local/var/tmp/sage/build/deformation-
d05941b.p0/src/generics.h:12:10: fatal error: 'mpir.h' file not found
  [deformation-d05941b.p0]   #include <mpir.h>
  [deformation-d05941b.p0]            ^~~~~~~~
  [deformation-d05941b.p0]   In file included from zero.c:1:
  [deformation-d05941b.p0]   In file included from
/Users/runner/work/sage/sage/.tox/local-homebrew-macos-
maximal/local/var/tmp/sage/build/deformation-d05941b.p0/src/vec.h:8:
  [deformation-d05941b.p0]   /Users/runner/work/sage/sage/.tox/local-
homebrew-macos-maximal/local/var/tmp/sage/build/deformation-
d05941b.p0/src/generics.h:12:10: fatal error: 'mpir.h' file not found
}}}

Is this package still maintained?

Also on `debian-bullseye`:
{{{
 [deformation-d05941b.p0]       CC   ../build/perm/../perm.lo
  [deformation-d05941b.p0]   /usr/bin/ld: -r and -pie may not be used
together
  [deformation-d05941b.p0]   collect2: error: ld returned 1 exit status
}}}

---

a straightforward modification of using GMP in place MPIR seems to work
just fine, at least on 64-bit linux. Please review.

URL: https://trac.sagemath.org/30325
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe, Dima Pasechnik
Reviewer(s): Matthias Koeppe
  • Loading branch information
Release Manager committed Jul 23, 2021
2 parents 0e26ac3 + 44b1d0a commit 776b1eb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
5 changes: 4 additions & 1 deletion build/pkgs/deformation/SPKG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@ GLPv3
Upstream Contact
----------------

- Sebastian Pancratz: sebastian.pancratz@gmail.com
- Sebastian Pancratz: sebastian.pancratz@gmail.com, sage-devel@googlegroups.com

- We use the fork at https://github.com/sagemath/deformation
the fork uses GMP instead of MPIR, and Flint 2.7+.
7 changes: 4 additions & 3 deletions build/pkgs/deformation/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
tarball=deformation-VERSION.tar.bz2
sha1=317fb76c884fa4b6b92ed0b171a0b9fdb3bdc90f
md5=e4af9b93ddc85ebb52d9fa1fedd75887
cksum=4134074975
sha1=0f5fd78a91da207d06b5be59bf466f16c2614eda
md5=e2c365e20778117d402fb664fc145d72
cksum=3789646827
upstream_url=https://github.com/sagemath/deformation/archive/refs/tags/VERSION.tar.gz
2 changes: 1 addition & 1 deletion build/pkgs/deformation/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d05941b.p0
20210503

0 comments on commit 776b1eb

Please sign in to comment.