#9799 breaks bdisted binaries (lacking pipestatus)

[jdemeyer]

spkg/pipestatus does not appear in binary distributions, but #9799 introduces the use of pipestatus in the top-level Makefile as well.

Also, ./sage -i ... etc. (i.e., sage-sage) should make use of pipestatus, cf. #9811.

Dependency: #9799

CC: @jhpalmieri

Component: distribution

Keywords: scripts

Author: Jeroen Demeyer

Reviewer: John Palmieri

Merged: sage-4.6.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10157

[jdemeyer]

Attachment: 10157_pipestatus.patch.gz

sage_scripts patch

[jdemeyer]

Author: Jeroen Demeyer

[nexttime]

comment:4

Good catch. I didn't know the bdists didn't have spkg/pipestatus.

[nexttime]

comment:6

In principle positive review; should test this of course (later).

[jdemeyer]

comment:7

If you thrust the author of the patch to do the test, I am doing the following:

• building Sage from source with Running "make" in SAGE_ROOT returns the wrong exit code, leading to all kinds of confusion #9799, Rename top-level makefile to Makefile #10156, #9799 breaks bdisted binaries (lacking pipestatus) #10157 applied and makefile renamed to Makefile
• making an sdist and a bdist from this built Sage
• extract the sdist, make, make ptestlong
• extract the bdist, make ptestlong

If all this works, I think that #10156 and #10157 are proven to work.

[jdemeyer]

comment:8

Replying to @nexttime:

Good catch. I didn't know the bdists didn't have spkg/pipestatus.

Well, the "catch" was made because the above recipe failed.

[jdemeyer]

comment:10

All builds and tests mentioned above worked with #9799, #10156, #10157 applied.

[jdemeyer]

Merged: sage-4.6.1.alpha0

[jdemeyer]

Changed merged from sage-4.6.1.alpha0 to sage-4.6.1.alpha1

[jhpalmieri]

comment:13

The patch looks completely sensible, and it's worked for me when I tested it out.

[jhpalmieri]

Reviewer: John Palmieri

[jdemeyer]

Changed merged from sage-4.6.1.alpha1 to sage-4.6.1.alpha0

[jdemeyer]

comment:14

Set "merged" to sage-4.6.1.alpha1 by mistake (this patch didn't change).