Some more doctests from the book "Calcul mathématique avec Sage"

[sagetrac-gconnan]

The attached patch adds to the Sage testsuite most examples appearing Chapter 9 (EDO, EDP, Recurrence) of the French book Calcul mathématique avec Sage.

Apply attachment: trac_11745.patch only.

Component: doctest coverage

Author: Guillaume Connan

Reviewer: Paul Zimmermann

Merged: sage-5.10.beta0

Issue created by migration from https://trac.sagemath.org/ticket/11745

[sagetrac-gconnan]

Attachment: recequadiff.2.py.gz

[sagetrac-gconnan]

Attachment: recequadiff.py.gz

Replying to @sagetrac-gconnan:

The attached patch adds to the Sage testsuite most examples appearing Chapter 9 (EDO, EDP, Recurrence) of the French book Calcul mathématique avec Sage.

All tests pass with sage 4.7.1.

[zimmermann6]

comment:3

Guillaume, which file is to be applied?

Paul

[zimmermann6]

Attachment: recequadiff_doctest.sage.gz

[zimmermann6]

comment:4

use only the attached file recequadiff_doctest.sage
This file has to be put into tests/french_book, probably after changing the name to
recequadiff.py. All tests pass with 5.7. I put it as "needs review" so that people can
comment.

Paul

PS: I do this for Guillaume who cannot login any more on trac.

[jdemeyer]

comment:6

Additions to Sage should be patches to the Sage library (in devel/sage). See http://sagemath.org/doc/developer/

[sagetrac-gconnan]

Attachment: recequadiff_doctest.2.sage.gz

Doctest for solving differential equations and recurrences

[zimmermann6]

comment:7

Attachment: trac_11745.patch.gz

[zimmermann6]

Author: Guillaume Connan

[zimmermann6]

comment:9

I give a positive review. In fact it is enough to test the single (attached) file, since it does not change any functionality in Sage, it does only add some more doctests.

Nevertheless I did run all doctests (with Sage 5.7) and they all pass.

Paul

PS: note I am a co-author of the french book. I hope it does not make a problem if I review this ticket. We should soon publish the book on paper, and thus we would like to ensure our
examples will still run in future versions of Sage.

[zimmermann6]

Reviewer: Paul Zimmermann

[jdemeyer]

comment:10

Paul: as I already said to you by e-mail, be sure to run the test with --warn-long and mark any tests taking a long time as # long time.

[zimmermann6]

comment:11

Jeroen, the --warn-long option does not seem to work with 5.7 nor 5.8:

tarte% ../../../../../sage -t --warn-long recequadiff.py
sage -t --warn-long "devel/sage-11745/sage/tests/french_book/recequadiff.py"


Usage: sage-doctest [same options as sage -t] filenames
         [0.1 s]
 
----------------------------------------------------------------------
The following tests failed:


        sage -t --warn-long "devel/sage-11745/sage/tests/french_book/recequadiff.py"
Total time for all tests: 0.2 seconds

Paul

[jdemeyer]

comment:12

True, it was introduced in sage-5.9.beta0.

[zimmermann6]

comment:13

Anyway on my machine (which is an Intel Core 2) numbertheory.py takes
about 15 seconds, polynomes.py about 5 seconds, and recequadiff.py
about 13 seconds (without -long). Is that reasonable?

Paul

[jdemeyer]

comment:15

Replying to @zimmermann6:

This file has to be put into tests/french_book, probably after changing the name to
recequadiff.py.

Let me just mention that there is no requirement from me to rename that file. It would have been fine to keep the name recequadiff_doctest.sage (maybe that's easier for you?)

[zimmermann6]

comment:16

since the first files in tests/french_book are named xxx.py, for coherence it is better to use similar names.

Paul

[jdemeyer]

Merged: sage-5.10.beta0

[zimmermann6]

comment:18

we have a new patch without the executable bit, and with ... replaced by ....:,
should be attach it here or in a new ticket?

Paul