get rid of CartesianProduct #18411

videlec · 2015-05-13T09:44:39Z

The features of sage.combinat.cartesian_product.CartesianProduct are now completely integrated into the category framework (see #18290). We remove all occurrences of CartesianProduct to either cartesian_product or itertools.product. We deprecate the CartesianProduct from sage.combinat.cartesian_product.

In order to support all features of the old class we also:

move the __iter__ from EnumeratedSets.CartesianProducts.ParentMethods to Sets.CartesianProducts.ParentMethods
allows cartesian_product to be called with list, tuple, set, frozenset
make cartesian_product([]) works
introduce a function some_tuples in sage.misc.misc that is intensively used in the testing framework (and incidentally speed up some doc test)
refine the category of Set([1,2,3]) to be finite
implement a (very naive) random_element for Set([1,2,3])
implement a (naive) hash for EnumeratedSetFromIterator

see also : #15425, #19195
one that can be closed as duplicate: #14224, #19192

Depends on #17411

CC: @nthiery @nathanncohen

Component: combinatorics

Author: Vincent Delecroix

Branch/Commit: 6e27dde

Reviewer: Nicolas M. Thiéry

Issue created by migration from https://trac.sagemath.org/ticket/18411

The text was updated successfully, but these errors were encountered:

videlec · 2015-05-13T11:44:28Z

Dependencies: #18290, #12955

videlec · 2015-09-07T19:38:57Z

Branch: public/18411

sagetrac-git · 2015-09-07T19:39:04Z

Commit: e703eb4

sagetrac-git · 2015-09-07T19:39:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e703eb4`	`Trac 18411: remove occurrences of CartesianProduct`

sagetrac-git · 2015-09-12T02:18:34Z

Changed commit from e703eb4 to 10df218

sagetrac-git · 2015-09-12T02:18:34Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`635279f`	`Trac 18411: a bounded_number_of_tuples function`
`1b60903`	`Trac 18411: remove occurrences of CartesianProduct`
`bec57ae`	`Trac 18411: cartesian_product works with tuple/list/set/frozenset`
`7dbb663`	`Trac 18411: move iteration of cartesian products to Sets`
`4fbb4ae`	`Trac 18411: refine category of Set(...)`
`10df218`	`Trac 18411: fix combinat tutorial`

videlec · 2015-09-12T02:22:17Z

Author: Vincent Delecroix

videlec · 2015-09-12T02:22:17Z

Changed dependencies from #18290, #12955 to none

sagetrac-git · 2015-09-12T09:56:10Z

Branch pushed to git repo; I updated commit sha1. New commits:

`57b82e3`	`trax #18411 fixing a typo and doctest continuation`

sagetrac-git · 2015-09-12T09:56:10Z

Changed commit from 10df218 to 57b82e3

videlec · 2015-09-12T13:47:06Z

comment:7

Thanks Frédéric for fixing a doctest. Though, I do not see the point of modifying src/sage/rings/quotient_ring.py. This file is completely unrelated to this ticket.

sagetrac-git · 2015-09-12T14:17:31Z

Changed commit from 57b82e3 to a640c24

sagetrac-git · 2015-09-12T14:17:31Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a640c24`	`trac #18411 fixing some doctests`

sagetrac-git · 2015-09-12T14:40:09Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`b650e69`	`trac #18411 fixing some doctests`
`0dcfed9`	`Trac 18411: fix combinat/partition_tuple`
`613cef5`	`Trac 18411: fix testing issues`
`3cc8070`	`Trac 18411: fix composition signed`

sagetrac-git · 2015-09-12T14:40:09Z

Changed commit from a640c24 to 3cc8070

videlec · 2015-09-12T14:41:33Z

comment:10

Hi Frédéric,

This was clearly not the way to fix composition_signed.py. I removed this change from your commit. The rest of my commits should fix all issues with timed out testing (ie root system and padic) as well as the issue with tableau tuples.

Vincent

sagetrac-git · 2015-09-12T17:19:58Z

Branch pushed to git repo; I updated commit sha1. New commits:

`70949c7`	`Trac 18411: fix two doctests`

sagetrac-git · 2015-09-12T17:19:58Z

Changed commit from 3cc8070 to 70949c7

sagetrac-git · 2015-09-12T17:31:55Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9beb023`	`Trac 18411: bound number of tests for Domains`

sagetrac-git · 2015-09-12T17:31:55Z

Changed commit from 70949c7 to 9beb023

sagetrac-git · 2015-09-12T17:41:34Z

Branch pushed to git repo; I updated commit sha1. New commits:

`6580825`	`Trac 18411: fix is_empty`

nthiery · 2015-10-16T22:17:04Z

comment:60

The change sounds fine to me! Assuming all test pass, back to positive review.

videlec · 2015-10-17T06:35:14Z

comment:61

... does not...

sagetrac-git · 2015-10-17T06:38:24Z

Changed commit from 525d038 to 41af762

sagetrac-git · 2015-10-17T06:38:24Z

Branch pushed to git repo; I updated commit sha1. New commits:

`41af762`	`Trac 18411: pass keywords in __call__`

videlec · 2015-10-17T06:38:53Z

comment:63

...waiting for the patchbot green light...

videlec · 2015-10-17T13:26:29Z

comment:64

Bueno!

vbraun · 2015-10-17T19:32:16Z

comment:65

Merge conflict

videlec · 2015-10-20T00:16:02Z

comment:66

With what?

sagetrac-git · 2015-10-22T02:41:05Z

Branch pushed to git repo; I updated commit sha1. New commits:

`6e27dde`	`Trac 18411: merge sage-6.10.beta1`

sagetrac-git · 2015-10-22T02:41:05Z

Changed commit from 41af762 to 6e27dde

videlec · 2015-10-22T02:42:17Z

comment:68

Hoping I will not have to rebase once more...

vbraun · 2015-10-23T17:28:11Z

Changed branch from public/18411 to 6e27dde

videlec added this to the sage-6.7 milestone May 13, 2015

videlec added c: combinatorics labels May 13, 2015

This comment has been minimized.

Sign in to view

videlec changed the title ~~Get rid of sage.combinat.cartesian_product~~ remove some CartesianProduct usages Sep 12, 2015

videlec added the s: needs review label Sep 12, 2015

This comment has been minimized.

Sign in to view

nthiery added s: positive review and removed s: needs review labels Oct 16, 2015

videlec added s: needs work and removed s: positive review labels Oct 17, 2015

videlec added s: positive review and removed s: needs work labels Oct 17, 2015

vbraun added s: needs work and removed s: positive review labels Oct 17, 2015

videlec added s: needs review and removed s: needs work labels Oct 22, 2015

vbraun removed the s: positive review label Oct 23, 2015

vbraun closed this as completed in 12a8a7f Oct 23, 2015

This was referenced Feb 5, 2016

random_element fails for a cartesian product of fields #9085

Closed

Meta-ticket: Cleanup cartesian products #15425

Open

fchapoton mentioned this issue Apr 9, 2020

remove several deprecated things #29439

Closed

videlec mentioned this issue Feb 11, 2023

Make tensor of CombinatorialFreeModule use cartesian_product, deprecate CartesianProduct_iters #19195

Open

get rid of CartesianProduct #18411

get rid of CartesianProduct #18411

Comments

videlec commented May 13, 2015

This comment has been minimized.

videlec commented May 13, 2015

videlec commented Sep 7, 2015

sagetrac-git mannequin commented Sep 7, 2015

sagetrac-git mannequin commented Sep 7, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

videlec commented Sep 12, 2015

This comment has been minimized.

videlec commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

videlec commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

videlec commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

sagetrac-git mannequin commented Sep 12, 2015

This comment has been minimized.

sagetrac-git mannequin commented Sep 12, 2015

nthiery commented Oct 16, 2015

videlec commented Oct 17, 2015

sagetrac-git mannequin commented Oct 17, 2015

sagetrac-git mannequin commented Oct 17, 2015

videlec commented Oct 17, 2015

videlec commented Oct 17, 2015

vbraun commented Oct 17, 2015

videlec commented Oct 20, 2015

sagetrac-git mannequin commented Oct 22, 2015

sagetrac-git mannequin commented Oct 22, 2015

videlec commented Oct 22, 2015

vbraun commented Oct 23, 2015