Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove several deprecated things #29439

Closed
fchapoton opened this issue Mar 31, 2020 · 9 comments
Closed

remove several deprecated things #29439

fchapoton opened this issue Mar 31, 2020 · 9 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.1

Comments

@fchapoton
Copy link
Contributor

after #18411, #17659, #18539

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: d7f0699

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29439
@fchapoton fchapoton added this to the sage-9.1 milestone Mar 31, 2020
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/29439

@fchapoton
Copy link
Contributor Author

New commits:

b5dad83remove several deprecated things

@fchapoton
Copy link
Contributor Author

Commit: b5dad83

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2020

Changed commit from b5dad83 to d7f0699

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

d7f0699trac 29439 remove one unused import (pyflakes)

@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Apr 1, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 1, 2020

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Apr 9, 2020

Changed branch from u/chapoton/29439 to d7f0699

@vbraun vbraun closed this as completed in f1cff5b Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton