categorial constructions, pushout and coercions (extended) for asymptotic ring and growth groups #19073

dkrenn · 2015-08-22T19:18:51Z

Extend coercions and deal with pushout constructions.

See also meta ticket #17601.

Depends on #17716
Depends on #18182
Depends on #19028
Depends on #18223

CC: @behackl

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: 8a32f1f

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19073

The text was updated successfully, but these errors were encountered:

dkrenn · 2015-08-22T19:19:15Z

Branch: u/dkrenn/asy/groups-coercion

sagetrac-git · 2015-08-24T17:43:06Z

Commit: a23d36e

sagetrac-git · 2015-08-24T17:43:06Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`225e240`	`new element constructor for cartesian products`
`296f432`	`combine_exceptions function`
`68988a8`	`fix a bug in element_constructor and rewrite it`
`7cd6018`	`rewrite repr of term`
`1b73481`	`correct a bug in term constructor`
`1cd896b`	`extend has coercion`
`287c0ae`	`make asymptotic ring a poset (Part I)`
`3030d88`	`variable_names`
`74f2db0`	`more cleanup and using generalizing methods for cartesian product`
`a23d36e`	`construction and functor and doctests`

sagetrac-git · 2015-08-24T17:49:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3b49e70`	`pushout: correct str/repr (switch to be constistent with remaining Sage)`
`a3b2cc6`	`Merge branch 'pushout/functor-str' into u/dakrenn/asy/rings-coercion`

sagetrac-git · 2015-08-24T17:49:08Z

Changed commit from a23d36e to a3b2cc6

sagetrac-git · 2015-08-25T07:43:00Z

Branch pushed to git repo; I updated commit sha1. New commits:

`19247a5`	`fix derived classes`
`dacbfcb`	more replacements of `__str__` by _repr_
`d1356e5`	`Merge branch 'pushout/functor-str' into u/dakrenn/asy/rings-coercion`
`27601ba`	`fix missing docs`
`e1acc40`	`improve docs (seealso, links, etc)`
`98e8860`	`make doctest coverage 100% (asymptotic_ring)`
`e9acd0e`	`cleanup (remove a comment)`

sagetrac-git · 2015-08-25T07:43:00Z

Changed commit from a3b2cc6 to e9acd0e

dkrenn · 2015-09-09T15:20:48Z

Changed dependencies from #17600, #18930, #18182, #19028, #18587, #18223, #18586 to #17600, #17716, #18930, #18182, #19028, #18587, #18223, #18586

sagetrac-git · 2015-09-14T18:34:52Z

Changed commit from e9acd0e to 963f9da

sagetrac-git · 2015-09-14T18:34:52Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`58f931d`	`add asymptotic_expansions index`
`39621ad`	`Merge branch 't/17600/asy/growthGroup' into t/19073/asy/groups-coercion`
`9d6f2da`	`Merge branch 't/17600/asy/growthGroup' into t/18930/asy/growthGroup-factory`
`6da5ade`	`Merge branch 't/18930/asy/growthGroup-factory' into t/17715/asy/asymptoticTerm`
`2c1c39d`	`Merge branch 't/17715/asy/asymptoticTerm' into t/17716/asy/asymptoticExpression`
`41a80a2`	`Merge branch 't/17716/asy/asymptoticExpression' into t/19073/asy/groups-coercion`
`ca5da4a`	`Merge branch 't/18930/asy/growthGroup-factory' into t/18587/asy/growth-group-cartesian`
`ac80aeb`	`add growth_group_cartesian to index`
`96f7101`	`Merge branch 't/18587/asy/growth-group-cartesian' into t/19028/asy/growthGroup-exponential`
`963f9da`	`Merge branch 't/19028/asy/growthGroup-exponential' into t/19073/asy/groups-coercion`

dkrenn · 2015-09-14T18:35:19Z

comment:10

merged 6.9.beta5

sagetrac-git · 2015-09-16T16:08:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`cd17673`	`Merge tag '6.9.beta6' into t/18182/18182-on-6.8`
`3eefe25`	`correct typo in AUTHORS`
`5fe52e4`	`fix doctests since name of cartesian product functor has changed`
`60b9375`	`revert changes in base_ring of category_object and adapt doctests`
`8d6de43`	`Merge remote-tracking branch 'trac/u/dkrenn/18182/pushout' into t/19073/asy/groups-coercion`

sagetrac-git · 2015-09-16T16:08:04Z

Changed commit from 963f9da to 8d6de43

dkrenn · 2015-09-16T16:14:35Z

comment:13

merged 6.9.beta6 (with #18182)

sagetrac-git · 2015-09-16T17:40:24Z

Changed commit from 8d6de43 to 6180b43

sagetrac-git · 2015-09-16T17:40:24Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c16587c`	`fix bug (tower has only one entry which is None)`
`6180b43`	`Merge branch 'u/dkrenn/18182/pushout' of trac.sagemath.org:sage into t/19073/asy/groups-coercion`

sagetrac-git · 2015-09-29T17:57:15Z

Changed commit from 6180b43 to 36e16a3

sagetrac-git · 2015-09-29T17:57:15Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`538e1e4`	`doctest for simplify-keyword`
`e98964b`	`remove superfluous doctest`
`5cf2a31`	`doctests for AsymptoticRing.__init__`
`dc00f95`	`improve documentation of _element_constructor_`
`abb08ff`	`improve _element_constructor_`
`78b9e96`	`Trac #17716: additional doctest`
`055e35b`	`Trac #17716: Fix ReSt error`
`e8e2501`	`make entry in reference/index`
`e86db32`	`Merge branch 'u/dkrenn/asy/asymptoticExpression' of trac.sagemath.org:sage into t/19073/asy/groups-coercion`
`36e16a3`	`fix doctests after merge`

dkrenn · 2015-09-29T17:57:39Z

comment:16

Merged in changes in dependencies.

sagetrac-git · 2015-09-30T09:25:11Z

Branch pushed to git repo; I updated commit sha1. New commits:

`dd82094`	`fix duplicated docstring-parts`

sagetrac-git · 2015-09-30T09:25:11Z

Changed commit from 36e16a3 to dd82094

cheuberg · 2015-10-04T14:14:25Z

Changed branch from u/dkrenn/asy/groups-coercion to u/cheuberg/asy/groups-coercion

sagetrac-git · 2015-10-08T14:54:13Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`bc70cb9`	`Trac #18182, comment 20, 7: rename CartesianProductPolys --> CartesianProductPoly`
`592a551`	`Merge branch 'u/dkrenn/coercion/pushout' of trac.sagemath.org:sage into t/19073/asy/groups-coercion`
`70aa9c4`	`rename CartesianProductPosets to CartesianProductPoset`
`f21990d`	`code-simplify CartesianProduct assignment`
`8f9a619`	`add a doctest dealing with coercion while comparing`
`3b923b7`	`Merge branch 'u/dkrenn/cat/cartesian-product-posets' of trac.sagemath.org:sage into t/18587/asy/growth-group-cartesian`
`74547e6`	`fix code after changes by previous merge`
`23c9a49`	`Merge branch 't/18587/asy/growth-group-cartesian' into t/19028/asy/growthGroup-exponential`
`09221f0`	`fixup due to changes in #18587 (coming from #18223)`
`311fc97`	`Merge branch 'u/dkrenn/asy/growthGroup-exponential' of trac.sagemath.org:sage into t/19073/asy/groups-coercion`

sagetrac-git · 2015-10-08T14:54:13Z

Changed commit from b306679 to 311fc97

dkrenn · 2015-10-08T14:56:02Z

comment:24

Merge in all dependencies.

dkrenn · 2015-10-08T15:12:59Z

Changed dependencies from #17600, #17716, #18930, #18182, #19028, #18587, #18223, #18586 to #17716, #18182, #19028, #18223, #18586

cheuberg · 2015-10-08T16:52:03Z

Changed branch from u/dkrenn/asy/groups-coercion to u/cheuberg/asy/groups-coercion

sagetrac-git · 2015-10-08T17:09:16Z

Changed commit from 311fc97 to 1583ffc

sagetrac-git · 2015-10-08T17:09:16Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2a80346`	`Trac #19073: simplify signatures of helper functions in merge_overlapping`
`1583ffc`	`Trac #19073: Reword and add doctest for _pushout_`

cheuberg · 2015-10-08T17:19:16Z

comment:28

Replying to @dkrenn:

Replying to @cheuberg:

Why is the default category now a monoid instead of a group?

A monoid is all what is needed to make the asymptotic ring a ring. Of course usually this will be a group to allow inversions in the ring, but as a minimal requirement, we have Monoids()

Ok, this explains why a GenericGrowthGroup is only a monoid.

The derived classes MonomialGrowthGroup and ExponentialGrowthGroup, however, will be groups in many cases.
Perhaps this can be resolved in or after #19083.

GenericGrowthGroup._pushout_:

explain why there is no common canonical parent for objects with parents: Growth Group QQ^x and Growth Group x^QQ (commutativity of pushouts vs. non-commutativity of cartesian products of growth groups with the same generator?)

Documented.

I reworded that and added further doctests.

find_mergedoverlapping_index: key is evaluated frequently

Now cached.

However, the helper functions only need the keys, I added a commit to do so.

Please cross-review my changes and add item 2. to the TODO list of #19083 or, alternatively, open a ticket for that.
After that, consider this to be a conditional positive_review from my side, conditional on #18182.

dkrenn · 2015-10-12T14:54:57Z

Changed branch from u/cheuberg/asy/groups-coercion to u/dkrenn/asy/groups-coercion

dkrenn · 2015-10-12T14:59:38Z

Changed commit from 1583ffc to 8a32f1f

dkrenn · 2015-10-12T14:59:38Z

comment:30

Replying to @cheuberg:

Replying to @dkrenn:

Replying to @cheuberg:

Why is the default category now a monoid instead of a group?

A monoid is all what is needed to make the asymptotic ring a ring. Of course usually this will be a group to allow inversions in the ring, but as a minimal requirement, we have Monoids()

Ok, this explains why a GenericGrowthGroup is only a monoid.

The derived classes MonomialGrowthGroup and ExponentialGrowthGroup, however, will be groups in many cases.
Perhaps this can be resolved in or after #19083.

Ok. Added it as a work issue on #19083.

GenericGrowthGroup._pushout_:

explain why there is no common canonical parent for objects with parents: Growth Group QQ^x and Growth Group x^QQ (commutativity of pushouts vs. non-commutativity of cartesian products of growth groups with the same generator?)

Documented.

I reworded that and added further doctests.

Corrected PEP8.

find_mergedoverlapping_index: key is evaluated frequently

Now cached.

However, the helper functions only need the keys, I added a commit to do so.

Thanks.

Please cross-review my changes and add item 2. to the TODO list of #19083 or, alternatively, open a ticket for that.
After that, consider this to be a conditional positive_review from my side, conditional on #18182.

Everything done.

New commits:

`8a32f1f`	`correct PEP8-spacings in doctest`

cheuberg · 2015-10-23T05:50:12Z

comment:31

Removed dependency on "duplicate" ticket #18586.

cheuberg · 2015-10-23T05:50:12Z

Changed dependencies from #17716, #18182, #19028, #18223, #18586 to #17716, #18182, #19028, #18223

vbraun · 2015-10-23T23:10:02Z

comment:32

This is probably due to one of the tickets in beta2, probably best to wait for the next release and then fix:

sage -t --long src/sage/combinat/rigged_configurations/kr_tableaux.py
**********************************************************************
File "src/sage/combinat/rigged_configurations/kr_tableaux.py", line 1671, in sage.combinat.rigged_configurations.kr_tableaux.KRTableauxTypeDTri2Element.e
Failed example:
    KRT.module_generators[0].e(0)
Exception raised:
    Traceback (most recent call last):
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.rigged_configurations.kr_tableaux.KRTableauxTypeDTri2Element.e[1]>", line 1, in <module>
        KRT.module_generators[Integer(0)].e(Integer(0))
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/rigged_configurations/kr_tableaux.py", line 1680, in e
        ret = ret.to_virtual_configuration().e(0)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/rigged_configurations/rigged_configuration_element.py", line 1327, in e
        ret = self.to_tensor_product_of_kirillov_reshetikhin_tableaux().e(a)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/crystals/tensor_product.py", line 1258, in e
        position = self.positions_of_unmatched_plus(i)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/crystals/tensor_product.py", line 1400, in positions_of_unmatched_plus
        l = self.positions_of_unmatched_minus(i, dual=True, reverse=True)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/crystals/tensor_product.py", line 1380, in positions_of_unmatched_minus
        plus = self[j].epsilon(i)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/rigged_configurations/kr_tableaux.py", line 1532, in epsilon
        return KirillovReshetikhinTableauxElement.epsilon(self, i)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/rigged_configurations/kr_tableaux.py", line 1373, in epsilon
        return self.to_kirillov_reshetikhin_crystal().epsilon0()
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/rigged_configurations/kr_tableaux.py", line 1160, in to_kirillov_reshetikhin_crystal
        return self.parent().kirillov_reshetikhin_crystal()(self)
      File "sage/structure/parent.pyx", line 1098, in sage.structure.parent.Parent.__call__ (/mnt/disk/home/buildslave-sage/slave/sage_git/build/src/build/cythonized/sage/structure/parent.c:9821)
        return mor._call_(x)
      File "sage/structure/coerce_maps.pyx", line 109, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/mnt/disk/home/buildslave-sage/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4543)
        raise
      File "sage/structure/coerce_maps.pyx", line 104, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/mnt/disk/home/buildslave-sage/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4436)
        return C._element_constructor(x)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/crystals/kirillov_reshetikhin.py", line 3024, in _element_constructor_
        return self.module_generator().f_string(f_str)
      File "/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/crystals/kirillov_reshetikhin.py", line 543, in module_generator
        return [ b for b in self.module_generators if b.weight() == weight][0]
    IndexError: list index out of range
**********************************************************************

vbraun · 2015-10-24T07:57:00Z

comment:33

Nevermind was casued by something else

vbraun · 2015-10-24T10:22:18Z

Changed branch from u/dkrenn/asy/groups-coercion to 8a32f1f

dkrenn added this to the sage-6.9 milestone Aug 22, 2015

dkrenn added c: symbolics labels Aug 22, 2015

This comment has been minimized.

Sign in to view

dkrenn added the s: needs review label Sep 2, 2015

dkrenn removed the c: symbolics label Sep 15, 2015

dkrenn added the s: needs review label Oct 8, 2015

dkrenn added s: positive review and removed s: needs review labels Oct 12, 2015

cheuberg modified the milestones: sage-6.9, sage-6.10 Oct 23, 2015

vbraun added s: needs work and removed s: positive review labels Oct 23, 2015

vbraun added s: positive review and removed s: needs work labels Oct 24, 2015

vbraun removed the s: positive review label Oct 24, 2015

vbraun closed this as completed in 7aa8d6f Oct 24, 2015

behackl mentioned this issue Dec 29, 2022

Meta ticket: Asymptotic Expansions in SageMath #17601

Open

dkrenn mentioned this issue Oct 24, 2015

AsymptoticRing: exp & log, cleanup, some improvements, documentation #19083

Closed

behackl mentioned this issue Oct 17, 2015

exp & log for the AsymptoticRing #19094

Closed

categorial constructions, pushout and coercions (extended) for asymptotic ring and growth groups #19073

categorial constructions, pushout and coercions (extended) for asymptotic ring and growth groups #19073

Comments

dkrenn commented Aug 22, 2015

dkrenn commented Aug 22, 2015

sagetrac-git mannequin commented Aug 24, 2015

sagetrac-git mannequin commented Aug 24, 2015

sagetrac-git mannequin commented Aug 24, 2015

sagetrac-git mannequin commented Aug 24, 2015

This comment has been minimized.

sagetrac-git mannequin commented Aug 25, 2015

sagetrac-git mannequin commented Aug 25, 2015

dkrenn commented Sep 9, 2015

sagetrac-git mannequin commented Sep 14, 2015

sagetrac-git mannequin commented Sep 14, 2015

dkrenn commented Sep 14, 2015

sagetrac-git mannequin commented Sep 16, 2015

sagetrac-git mannequin commented Sep 16, 2015

dkrenn commented Sep 16, 2015

sagetrac-git mannequin commented Sep 16, 2015

sagetrac-git mannequin commented Sep 16, 2015

sagetrac-git mannequin commented Sep 29, 2015

sagetrac-git mannequin commented Sep 29, 2015

dkrenn commented Sep 29, 2015

sagetrac-git mannequin commented Sep 30, 2015

sagetrac-git mannequin commented Sep 30, 2015

cheuberg commented Oct 4, 2015

sagetrac-git mannequin commented Oct 8, 2015

sagetrac-git mannequin commented Oct 8, 2015

dkrenn commented Oct 8, 2015

dkrenn commented Oct 8, 2015

cheuberg commented Oct 8, 2015

sagetrac-git mannequin commented Oct 8, 2015

sagetrac-git mannequin commented Oct 8, 2015

cheuberg commented Oct 8, 2015

dkrenn commented Oct 12, 2015

dkrenn commented Oct 12, 2015

dkrenn commented Oct 12, 2015

cheuberg commented Oct 23, 2015

cheuberg commented Oct 23, 2015

vbraun commented Oct 23, 2015

vbraun commented Oct 24, 2015

vbraun commented Oct 24, 2015