Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gen_py.python to gen.pyx #19888

Closed
jdemeyer opened this issue Jan 14, 2016 · 8 comments
Closed

Move gen_py.python to gen.pyx #19888

jdemeyer opened this issue Jan 14, 2016 · 8 comments
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-7.0

Comments

@jdemeyer
Copy link

There is no reason for gen_py.py to be a separate file. We move the function python() to a cpdef function gentoobj() (mirroring the already existing function objtogen()).

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: 581fc93

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/19888
@jdemeyer jdemeyer added this to the sage-7.0 milestone Jan 14, 2016
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Move gen_py.python into the gen class Move gen_py.python to gen.pyx Jan 14, 2016
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/19888

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2016

Commit: 6da8af9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6da8af9Move gen_py.python to gen.pyx

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

581fc93Fix doctest failures

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 14, 2016

Changed commit from 6da8af9 to 581fc93

@vbraun
Copy link
Member

vbraun commented Jan 15, 2016

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Jan 20, 2016

Changed branch from u/jdemeyer/ticket/19888 to 581fc93

@vbraun vbraun closed this as completed in 8e1c286 Jan 20, 2016
@jdemeyer jdemeyer mentioned this issue Nov 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.0
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer