Remove a lot of deprecated code

[jdemeyer]

Remove code deprecated in #2536, #13605, #14469, #16930, #16983, #16878, #17229, #17443, #17451, #17686, #18558, #19694, #19888, #20015, #20253, #20318, #20442, #21141, #21145, #21148, #21376, #21435

This includes a lot of deprecations for cmp instead of key for sorting.

Component: misc

Author: Jeroen Demeyer

Branch/Commit: aae6e54

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24103

[jdemeyer]

Branch: u/jdemeyer/remove_a_lot_of_deprecated_code

[jdemeyer]

New commits:

1b28d3d

Remove a lot of deprecated code

[jdemeyer]

Commit: 1b28d3d

[jdemeyer]

Author: Jeroen Demeyer

[tscrim]

comment:5

Lots of failing tests because you missed this line in words.py:

self.cmp_letters = self._cmp_letters  # deprecated

Actually, you should be able to remove cmp_letters as well.

[tscrim]

Reviewer: Travis Scrimshaw

[jdemeyer]

comment:6

Adding #21376

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e26c8e8

Remove a lot of deprecated code

[sagetrac-git]

Changed commit from 1b28d3d to e26c8e8

[tscrim]

comment:10

I would say either the failing doctest in doctest/control.py is invalid because it was checking the deprecation warning or it is now the correct output. However, since you wrote that, I guess you would know. :P

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a3589de

Remove a lot of deprecated code

[sagetrac-git]

Changed commit from e26c8e8 to a3589de

[tscrim]

comment:13

LGTM.

[vbraun]

comment:14

Merge conflict

[sagetrac-git]

Changed commit from a3589de to aae6e54

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

aae6e54

Remove a lot of deprecated code

[jdemeyer]

comment:17

I reverted the conflicting change in words.py (involving cmp_letters). This way, the rest of this branch can still be merged.

[vbraun]

Changed branch from u/jdemeyer/remove_a_lot_of_deprecated_code to aae6e54