More tests for common MIP TestSuite: add_col, solve; some fixes for backends #20424

mkoeppe · 2016-04-11T19:08:53Z

Split out from #20323.

This patch adds new _test methods for add_col, solve, and for #18572 (but disabled for CVXOPT, where it fails).
To make the new test methods happy,

implement add_col for Gurobi;
fix the implementation of add_col for COIN;
fix Gurobi's treatment of unbounded variables;
fix CPLEX unboundedness detection.

If anyone at all cares about the CVXOPT backend, perhaps they could fix it?

From dimpase:
I recall asking how one deals with different backends producing different, albeit equivalent, outputs. E.g. some of them would even introduce extra variables for some constraints (see e.g. #13148 comment:2). Some backends assign names to constraints automatically.

Depends on #20323
Depends on #20600
Depends on #20325

CC: @dimpase @videlec @jdemeyer @fchapoton @nbruin

Component: numerical

Author: Matthias Koeppe

Branch: 97c4542

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/20424

The text was updated successfully, but these errors were encountered:

mkoeppe · 2016-04-12T05:00:39Z

Branch: u/mkoeppe/backend_testsuite_failing_tests

mkoeppe · 2016-04-12T05:01:20Z

Commit: e5e6227

mkoeppe · 2016-04-12T05:01:20Z

comment:3

Branch is on top of #20323.

Last 10 new commits:

`d93b798`	`Change from mutating instance _test methods to class methods`
`94a4ac5`	`New method _test_ncols_nonnegative`
`2251125`	`GenericBackend: Remove failing _test methods from this ticket to make the patchbot and its friends happy`
`934456f`	`Revert "GenericBackend: Remove failing _test methods from this ticket to make the patchbot and its friends happy"`
`a85cada`	`_test_copy: New`
`8070754`	`_test_copy_does_not_share_data: New`
`d04b270`	`Test backend.copy() rather than copy(backend)`
`480a71b`	`test_copy_some_mips: New`
`3b49831`	`Add _test_solve_trac_18572 (autogenerated)`
`e5e6227`	`_test_solve_trac_18572: Replace float integers by integers to make test suitable for PPL backend`

sagetrac-git · 2016-04-13T22:58:34Z

Changed commit from e5e6227 to af1e885

sagetrac-git · 2016-04-13T22:58:34Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`48b9fe5`	`Change from mutating instance _test methods to class methods`
`5394729`	`New method _test_ncols_nonnegative`
`7138fa0`	`GenericBackend: Remove failing _test methods from this ticket to make the patchbot and its friends happy`
`9f4f25c`	`Revert "GenericBackend: Remove failing _test methods from this ticket to make the patchbot and its friends happy"`
`8421950`	`_test_copy: New`
`3f0578b`	`_test_copy_does_not_share_data: New`
`f5b42b8`	`Test backend.copy() rather than copy(backend)`
`f21ce7c`	`test_copy_some_mips: New`
`21abe28`	`Add _test_solve_trac_18572 (autogenerated)`
`af1e885`	`_test_solve_trac_18572: Replace float integers by integers to make test suitable for PPL backend`

mkoeppe · 2016-04-13T22:59:11Z

comment:5

Rebased on top of #20323 branch on top of 7.2.beta4

sagetrac-git · 2016-04-21T22:57:07Z

Changed commit from af1e885 to a5a1c60

sagetrac-git · 2016-04-21T22:57:07Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`6d01dc8`	`Revert "GenericBackend: Remove failing _test methods from this ticket to make the patchbot and its friends happy"`
`850b817`	`Add _test_solve_trac_18572 (autogenerated)`
`a5a1c60`	`_test_solve_trac_18572: Replace float integers by integers to make test suitable for PPL backend`

mkoeppe · 2016-04-21T22:58:01Z

comment:7

Rebased on top of 7.2.beta5.
Dropped "Test backend.copy() rather than copy(backend)".

dimpase · 2016-04-27T08:27:29Z

comment:8

How do you do test autogeneration (mentioned in 850b817) ?

mkoeppe · 2016-04-27T08:30:27Z

comment:9

The test method added in this commit is the raw output from #20376 (LoggingBackend) when run on the testcase of #18572.

sagetrac-git · 2016-04-29T06:17:07Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`cc0d326`	`Revert "GenericBackend: Remove failing _test methods from this ticket to make the patchbot and its friends happy"`
`6cd0b4a`	`Add _test_solve_trac_18572 (autogenerated)`
`492534d`	`_test_solve_trac_18572: Replace float integers by integers to make test suitable for PPL backend`
`658972c`	`Fix doctests when Gurobi is installed`
`cfaf157`	`Instead of running MixedIntegerLinearProgram doctests with the default solver, use GLPK`
`bb7f5de`	`Merge branch 't/20328/tests_related_to_cplex___gurobi' into t/20424/backend_testsuite_failing_tests`

sagetrac-git · 2016-04-29T06:17:07Z

Changed commit from a5a1c60 to bb7f5de

mkoeppe · 2016-04-29T06:19:05Z

comment:11

rebased on 7.2.beta6

sagetrac-git · 2016-05-26T18:55:40Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`f0ead34`	`CPLEXBackend: Use CPXgetstat to properly detect unboundedness`
`4aeaf9b`	`GurobiBackend.add_col: Implement`
`a65f66b`	`GenericBackend._test_add_col: New`
`51c2116`	`GurobiBackend.add_variable: Support coefficients keyword`
`c2eb25d`	`GurobiBackend: Fix GRB_INFINITY confusion`
`6adf3d9`	`CVXOPTBackend: Don't test _test_solve because of #18572`
`def61de`	`Add _test_solve_trac_18572 (autogenerated)`
`9f287a3`	`_test_solve_trac_18572: Replace float integers by integers to make test suitable for PPL backend`
`b60d790`	`CVXOPTBackend: Disable _test_solve_trac_18572 because of #18572`
`07c9c5d`	`GLPKExactBackend: Adjust output`

sagetrac-git · 2016-05-26T18:55:40Z

Changed commit from bb7f5de to 07c9c5d

mkoeppe · 2016-05-26T18:58:12Z

Changed dependencies from #20323 to #20323,#20600,#20325

sagetrac-git · 2016-05-30T20:49:18Z

Changed commit from 07c9c5d to 1ce4eb6

sagetrac-git · 2016-05-30T20:49:18Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1ce4eb6`	`CoinBackend.add_col: Use all coefficients`

sagetrac-git · 2016-06-25T00:36:36Z

Changed commit from 1ce4eb6 to 97c4542

sagetrac-git · 2016-06-25T00:36:36Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`e43bdc9`	`GurobiBackend.add_col: Implement`
`f42bd1c`	`GenericBackend._test_add_col: New`
`d4eccf6`	`GurobiBackend.add_variable: Support coefficients keyword`
`e9eb094`	`GurobiBackend: Fix GRB_INFINITY confusion`
`bc739f3`	`CVXOPTBackend: Don't test _test_solve because of #18572`
`9639a1f`	`Add _test_solve_trac_18572 (autogenerated)`
`c2bb379`	`_test_solve_trac_18572: Replace float integers by integers to make test suitable for PPL backend`
`0d75d6e`	`CVXOPTBackend: Disable _test_solve_trac_18572 because of #18572`
`b2b3031`	`GLPKExactBackend: Adjust output`
`97c4542`	`CoinBackend.add_col: Use all coefficients`

mkoeppe · 2016-06-25T00:38:48Z

comment:18

rebased on 7.3.beta5

dimpase · 2016-06-25T14:21:50Z

Reviewer: Dima Pasechnik

dimpase · 2016-06-25T14:21:50Z

comment:19

looks good to me

vbraun · 2016-06-26T07:30:14Z

Changed branch from u/mkoeppe/backend_testsuite_failing_tests to 97c4542

jdemeyer · 2017-08-09T10:33:10Z

Changed commit from 97c4542 to none

jdemeyer · 2017-08-09T10:33:10Z

comment:21

Replying to @sagetrac-git:


d4eccf6	`GurobiBackend.add_variable: Support coefficients keyword`

Are there any plans to support this for other backends? I noticed that it's not even documented in add_variable.__doc__ for the Gurobi backend.

The interface between backends should be consistent, so even just raise NotImplementedError("the foo backend does not support the 'coefficients' argument") in other backends would be good to have. What do you think?

dimpase · 2017-08-09T19:31:14Z

comment:22

IMHO different backends might have different features, which might be impossible to have for each backend.

Only if there are multiple backend supporting this, we can think of adding it to the generic backend, with the default implementation as you propose.

mkoeppe · 2017-08-09T20:07:23Z

comment:23

Replying to @jdemeyer:

Replying to @sagetrac-git:

d4eccf6 GurobiBackend.add_variable: Support coefficients keyword

Are there any plans to support this for other backends? I noticed that it's not even documented in add_variable.__doc__ for the Gurobi backend.

Yes, there is a plan, see #20324.

mkoeppe added this to the sage-7.2 milestone Apr 11, 2016

mkoeppe added c: numerical labels Apr 11, 2016

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label May 26, 2016

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~More tests for common MIP TestSuite~~ More tests for common MIP TestSuite: add_col, solve; some fixes for backends May 26, 2016

This comment has been minimized.

Sign in to view

dimpase modified the milestones: sage-7.2, sage-7.3 Jun 25, 2016

dimpase added s: positive review and removed s: needs review labels Jun 25, 2016

vbraun removed the s: positive review label Jun 26, 2016

vbraun closed this as completed in 8012bce Jun 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More tests for common MIP TestSuite: add_col, solve; some fixes for backends #20424

More tests for common MIP TestSuite: add_col, solve; some fixes for backends #20424

mkoeppe commented Apr 11, 2016

This comment has been minimized.

mkoeppe commented Apr 12, 2016

mkoeppe commented Apr 12, 2016

mkoeppe commented Apr 12, 2016

sagetrac-git mannequin commented Apr 13, 2016

sagetrac-git mannequin commented Apr 13, 2016

mkoeppe commented Apr 13, 2016

sagetrac-git mannequin commented Apr 21, 2016

sagetrac-git mannequin commented Apr 21, 2016

mkoeppe commented Apr 21, 2016

dimpase commented Apr 27, 2016

mkoeppe commented Apr 27, 2016

sagetrac-git mannequin commented Apr 29, 2016

sagetrac-git mannequin commented Apr 29, 2016

mkoeppe commented Apr 29, 2016

sagetrac-git mannequin commented May 26, 2016

sagetrac-git mannequin commented May 26, 2016

mkoeppe commented May 26, 2016

This comment has been minimized.

sagetrac-git mannequin commented May 30, 2016

sagetrac-git mannequin commented May 30, 2016

This comment has been minimized.

sagetrac-git mannequin commented Jun 25, 2016

sagetrac-git mannequin commented Jun 25, 2016

mkoeppe commented Jun 25, 2016

dimpase commented Jun 25, 2016

dimpase commented Jun 25, 2016

vbraun commented Jun 26, 2016

jdemeyer commented Aug 9, 2017

jdemeyer commented Aug 9, 2017

dimpase commented Aug 9, 2017

mkoeppe commented Aug 9, 2017

More tests for common MIP TestSuite: add_col, solve; some fixes for backends #20424

More tests for common MIP TestSuite: add_col, solve; some fixes for backends #20424

Comments

mkoeppe commented Apr 11, 2016

This comment has been minimized.

mkoeppe commented Apr 12, 2016

mkoeppe commented Apr 12, 2016

mkoeppe commented Apr 12, 2016

sagetrac-git mannequin commented Apr 13, 2016

sagetrac-git mannequin commented Apr 13, 2016

mkoeppe commented Apr 13, 2016

sagetrac-git mannequin commented Apr 21, 2016

sagetrac-git mannequin commented Apr 21, 2016

mkoeppe commented Apr 21, 2016

dimpase commented Apr 27, 2016

mkoeppe commented Apr 27, 2016

sagetrac-git mannequin commented Apr 29, 2016

sagetrac-git mannequin commented Apr 29, 2016

mkoeppe commented Apr 29, 2016

sagetrac-git mannequin commented May 26, 2016

sagetrac-git mannequin commented May 26, 2016

mkoeppe commented May 26, 2016

This comment has been minimized.

sagetrac-git mannequin commented May 30, 2016

sagetrac-git mannequin commented May 30, 2016

This comment has been minimized.

sagetrac-git mannequin commented Jun 25, 2016

sagetrac-git mannequin commented Jun 25, 2016

mkoeppe commented Jun 25, 2016

dimpase commented Jun 25, 2016

dimpase commented Jun 25, 2016

vbraun commented Jun 26, 2016

jdemeyer commented Aug 9, 2017

jdemeyer commented Aug 9, 2017

dimpase commented Aug 9, 2017

mkoeppe commented Aug 9, 2017