Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsymptoticRingFunctor does not deal with derived classes #22392

Closed
dkrenn opened this issue Feb 19, 2017 · 10 comments
Closed

AsymptoticRingFunctor does not deal with derived classes #22392

dkrenn opened this issue Feb 19, 2017 · 10 comments
Labels
c: asymptotic expansions p: major / 3 t: bug
Milestone
sage-7.6

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 19, 2017

We should have

            sage: from sage.rings.asymptotic.asymptotic_ring import AsymptoticRing
            sage: class MyAsymptoticRing(AsymptoticRing):
            ....:     pass
            sage: A = MyAsymptoticRing(growth_group='x^ZZ', coefficient_ring=QQ)

            sage: C = CyclotomicField(3)
            sage: P = C['z']
            sage: type(P(2) * A.gen())
            <class '...MyAsymptoticRing_with_category.element_class'>

but the element returned is has type AsymptoticRing (without the My).

CC: @cheuberg @behackl

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: 4dce6f5

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/22392
@dkrenn dkrenn added this to the sage-7.6 milestone Feb 19, 2017
@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 19, 2017

Branch: u/dkrenn/asy-functor-derive-bug

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 19, 2017

Commit: f6d4502

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 19, 2017

New commits:

4ddcdc3Trac #22392: new parameter cls
45728ffTrac #22392: pass cls from AsymptoticRing.construction
0982d06Trac #22392: use new parameter cls
f6d4502Trac #22392: adapt repr

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 19, 2017

Author: Daniel Krenn

@cheuberg
Copy link
Contributor

Changed branch from u/dkrenn/asy-functor-derive-bug to u/cheuberg/asy-functor-derive-bug

@cheuberg
Copy link
Contributor

Changed commit from f6d4502 to 4dce6f5

@cheuberg
Copy link
Contributor

comment:4

LGTM. Added one reviewer commit (mention trac ticket in Tests).

New commits:

4dce6f5Trac #22392: Mention Trac Ticket in Tests

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 21, 2017

comment:5

Replying to @cheuberg:

LGTM. Added one reviewer commit (mention trac ticket in Tests).

Thank you.

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@vbraun
Copy link
Member

vbraun commented Feb 26, 2017

Changed branch from u/cheuberg/asy-functor-derive-bug to 4dce6f5

@vbraun vbraun closed this as completed in ca2dfe0 Feb 26, 2017
@dkrenn dkrenn mentioned this issue Feb 26, 2017
Closed
dimpase pushed a commit to tornaria/sage that referenced this issue Feb 7, 2023
@dkrenn
Merge branch 'public/polynomials/laurent_mpoly_constructor-21976' of …
3a3aec5 
…git://trac.sagemath.org/sage into t/22067/gf-polyhedron

* 'public/polynomials/laurent_mpoly_constructor-21976' of git://trac.sagemath.org/sage: (709 commits)
  Some reviewer changes.
  Updated SageMath version to 7.6.beta5
  py3: remove usage of `_richcmp` in complex fields
  a few conversions from _cmp_ to _richcmp_
  Trac sagemath#22404: forgotten change in doctest
  Allow custom CXXFLAGS for pynac
  Mark surf as experimental
  List surf dependencies, do not build by default
  some doc cleanup in ell_rational_field and 2 neighbor files
  Trac sagemath#22398: py3: fix <type 'tuple'>
  trac 21592 some missing accents
  Clean up pynac interface
  py3 compatibility
  Trac sagemath#22404: add blanks after commas (except for tuples representing exponents) in polydict
  Improvements and some cleanup to ETuple.
  Trac sagemath#22396: mention Trac ticket in Tests
  Trac sagemath#22392: Mention Trac Ticket in Tests
  Trac sagemath#22402: PEP8: fix trailing whitespace
  Trac sagemath#22398: simplify id(...) = id(...) in doctest
  Trac sagemath#22398: doctest non-modifying input
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: asymptotic expansions p: major / 3 t: bug
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @cheuberg @dkrenn