Polybori segfaults when built with clang on OS X #22677

kiwifb · 2017-03-24T06:59:15Z

Split from #12426. Doctest involving polybori segfault when everything is built with clang

sage -t --long --warn-long 62.3 src/sage/rings/polynomial/multi_polynomial_sequence.py
**********************************************************************
File "src/sage/rings/polynomial/multi_polynomial_sequence.py", line 106, in sage.rings.polynomial.multi_polynomial_sequence
Failed example:
    C[0].groebner_basis()
Exception raised:
    Traceback (most recent call last):
      File "/Users/fbissey/build/sage-clang/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 498, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/fbissey/build/sage-clang/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 861, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.rings.polynomial.multi_polynomial_sequence[7]>", line 1, in <module>
        C[Integer(0)].groebner_basis()
      File "/Users/fbissey/build/sage-clang/local/lib/python2.7/site-packages/sage/rings/polynomial/multi_polynomial_sequence.py", line 518, in groebner_basis
        return self.ideal().groebner_basis(*args, **kwargs)
      File "sage/rings/polynomial/pbori.pyx", line 5080, in sage.rings.polynomial.pbori.BooleanPolynomialIdeal.groebner_basis (/Users/fbissey/build/sage-clang/src/build/cythonized/sage/rings/polynomial/pbori.cpp:42498)
        sig_on()
      File "src/cysignals/signals.pyx", line 109, in cysignals.signals.sig_raise_exception (build/src/cysignals/signals.c:1695)
    SignalError: Segmentation fault
    Killed due to segmentation fault

Backtrace

sage: F.eliminate_linear_variables() # everything vanishes ## line 1147 ##
------------------------------------------------------------------------
0   signals.so                          0x000000010589c5d1 print_backtrace + 65
1   signals.so                          0x000000010589fc0c sigdie + 60
2   signals.so                          0x000000010589fb7f cysigs_signal_handler + 351
3   libsystem_platform.dylib            0x00007fffd0769bba _sigtramp + 26
4   ???                                 0x00000001052a9a00 0x0 + 4381645312
5   pbori.so                            0x000000010f0257ef _ZN8polybori8groebner11linalg_stepERNSt3__16vectorINS_15BoolePolynomialENS1_9allocatorIS3_EEEENS_8BooleSetES8_bbPKc + 479
6   pbori.so                            0x000000010f0252d3 _ZN8polybori8groebner14gauss_on_polysERKNSt3__16vectorINS_15BoolePolynomialENS1_9allocatorIS3_EEEE + 275
7   pbori.so                            0x000000010f024fe0 _ZL58__pyx_pw_4sage_5rings_10polynomial_5pbori_39gauss_on_polysP7_objectS0_ + 192
8   libpython2.7.dylib                  0x000000010514cfdc PyEval_EvalFrameEx + 29500
9   libpython2.7.dylib                  0x0000000105151e02 fast_function + 338

Similarly sage/rings/polynomial/pbori.pyx

Assertion failed: (result != map.end()), function get, file ../../groebner/include/polybori/groebner/PolyEntryIndices.h, line 115.
------------------------------------------------------------------------
0   signals.so                          0x000000010bc6a5d1 print_backtrace + 65
1   signals.so                          0x000000010bc6dc0c sigdie + 60
2   signals.so                          0x000000010bc6db5d cysigs_signal_handler + 317
3   libsystem_platform.dylib            0x00007fffd0769bba _sigtramp + 26
4   ???                                 0x00007fd399cbd6a0 0x0 + 140546795099808
5   libsystem_c.dylib                   0x00007fffd05f0420 abort + 129
6   libsystem_c.dylib                   0x00007fffd05b7893 basename_r + 0
7   libbrial_groebner.0.dylib           0x0000000115658737 _ZNK8polybori8groebner16PolyEntryIndices3getINSt3__13mapINS_13BooleExponentEiNS_13MapComparatorIS5_EENS3_9allocatorINS3_4pairIKS5_iEEEEEES5_EEiRKT_RKT0_NS1_7uncheckE + 551
8   libbrial_groebner.0.dylib           0x00000001156584ff _ZNK8polybori8groebner16PolyEntryIndices3getINS1_7uncheckEEEiRKNS_13BooleExponentET_ + 47
9   libbrial_groebner.0.dylib           0x00000001156584bd _ZNK8polybori8groebner16PolyEntryIndicesclINS_13BooleExponentEEEiRKT_ + 29
10  libbrial_groebner.0.dylib           0x000000011561105c _ZNK8polybori8groebner15PolyEntryVector5indexINS_13BooleExponentEEEmRKT_ + 44
11  libbrial_groebner.0.dylib           0x00000001156609ad _ZN8polybori8groebner15PolyEntryVectorclINS_13BooleExponentEEENS0_18PolyEntryReferenceERKT_ + 61
12  libbrial_groebner.0.dylib           0x0000000115692ea7 _ZNK8polybori8groebner20SetAssociatedMinimalINS_13BooleExponentELb0EEclERKS2_ + 39
13  libbrial_groebner.0.dylib           0x000000011569108a _ZN8polybori8groebner17ReductionStrategy28unmarkNonMinimalLeadingTermsENS_8BooleSetE + 186
14  libbrial_groebner.0.dylib           0x0000000115690e16 _ZN8polybori8groebner17ReductionStrategy19setupSetsForElementERKNS0_9PolyEntryE + 262
15  pbori.so                            0x00000001153af381 _ZL76__pyx_pw_4sage_5rings_10polynomial_5pbori_17ReductionStrategy_5add_generatorP7_objectS0_ + 177
16  pbori.so                            0x000000011533967a _ZL25__Pyx_PyObject_CallOneArgP7_objectS0_ + 154
17  pbori.so                            0x00000001153974b1 _ZL71__pyx_pw_4sage_5rings_10polynomial_5pbori_17BooleanPolynomial_129reduceP7_objectS0_ + 2289
18  libpython2.7.dylib                  0x000000010b51bfdc PyEval_EvalFrameEx + 29500
19  libpython2.7.dylib                  0x000000010b514927 PyEval_EvalCodeEx + 2119

finally the failures in

sage -t --long src/sage/crypto/mq/sr.py  # 7 doctests failed

are consequences of segfaults above.

tarball https://github.com/BRiAl/BRiAl/releases/download/0.8.7/brial-0.8.7.tar.bz2

Upstream: Fixed upstream, in a later stable release.

Component: porting

Author: François Bissey, Dima Pasechnik

Branch/Commit: 382b25c

Reviewer: François Bissey, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/22677

The text was updated successfully, but these errors were encountered:

kiwifb · 2017-03-24T08:19:26Z

Upstream: Fixed upstream, but not in a stable release.

kiwifb · 2017-03-24T08:19:26Z

comment:1

All the above are solved by upgrading BRiAl to git master. I'll prepare a release of BRiAl.

dimpase · 2017-03-29T23:55:56Z

Commit: a3e4c6b

dimpase · 2017-03-29T23:55:56Z

Author: Dima Pasechnik

dimpase · 2017-03-29T23:55:56Z

comment:2

I need this for #22679 :-)

New commits:

`a3e4c6b`	`brial updated to commit 63f747626822f5e0fa2bf975f7801fcc988eb530`

dimpase · 2017-03-29T23:55:56Z

Branch: u/dimpase/brial086

kiwifb · 2017-03-30T00:16:12Z

comment:4

I know, sorry I cannot seem to move my ass to make a proper release. On it now.

kiwifb · 2017-03-30T00:40:57Z

Changed upstream from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.

kiwifb · 2017-03-30T00:40:57Z

comment:5

Need to fix the checksum to the properly released tarball. I'll put it back in review once it is done.

kiwifb · 2017-03-30T01:12:08Z

Changed commit from a3e4c6b to 0943ae5

kiwifb · 2017-03-30T01:12:08Z

Reviewer: François Bissey

kiwifb · 2017-03-30T01:12:08Z

comment:6

I'll put it in positive review but can you double check that the new tarball works for you.

New commits:

`0943ae5`	`updating checksum for official release`

kiwifb · 2017-03-30T01:12:08Z

Changed branch from u/dimpase/brial086 to u/fbissey/brial-0.8.6

dimpase · 2017-03-30T13:12:38Z

comment:7

ironically, it does not work on gentoo Lunix with gcc 5.4.0.

sage -t --long --warn-long 118.6 src/sage/rings/polynomial/multi_polynomial_sequence.py  # Killed due to segmentation fault

and two more brial-related errors.
While numerous

warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

are probably OK,

[sagelib-7.6] In file included from /home/dima/Sage/sage-dev/src/sage/libs/polybori/pb_wrap.h:22:0,
 from /home/dima/Sage/sage-dev/src/build/cythonized/sage/rings/polynomial/pbori.cpp:517:
/home/dima/Sage/sage-dev/src/sage/ext/ccobject.h: In instantiation of ‘void Delete(T*) [with T = polybori::groebner::ReductionStrategy]’:
 /home/dima/Sage/sage-dev/src/build/cythonized/sage/rings/polynomial/pbori.cpp:50398:51:   required from here
 /home/dima/Sage/sage-dev/src/sage/ext/ccobject.h:77:3: warning: 
deleting object of polymorphic class type ‘polybori::groebner::ReductionStrategy’ 
which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
   delete mem;
   ^

might spell trouble.
It could also be that we must switch to gcc 6. Can you check in what Linux configuration this works for you?

(meahwhile I'll do distclean and a full rebuild, just to see if this still persists)

kiwifb · 2017-03-30T19:02:58Z

comment:8

I confirm, it breaks things here too with gcc-5.4.0. I think it may be down to BRiAl/BRiAl#11 (comment) I'll have to check on that.

dimpase · 2017-03-30T19:37:39Z

comment:9

I'll have a look at how it plays together with #22554 (which isn't in this branch yet).

dimpase · 2017-03-31T00:39:11Z

comment:10

Replying to @dimpase:

I'll have a look at how it plays together with #22554 (which isn't in this branch yet).

no, it does not help.

kiwifb · 2017-03-31T11:23:19Z

comment:11

OK I have a fix. I cut a bit too much stuff. Actually adding one character would have been sufficient to fix gcc-6 compilation. It is still worth cleaning some stuff that wouldn't work anyway. I am not sure when I will have time to push the fix, I am rather busy this week end.

kiwifb · 2017-04-03T02:00:41Z

comment:12

brial-0.8.7 (now linked to in the ticket description) should work for all reasonably recent compilers. I am not sure about keeping -std=c++98 in CXXFLAGS as it could cause problem in the near future I think. I haven't updated the branch yet, feel free to beat me to it.

dimpase · 2017-04-04T08:59:23Z

comment:13

0.8.7 works well on FreeBSD+clang. I'm happy to give it positive review once we have a branch...

kiwifb · 2017-04-04T09:01:40Z

comment:14

Did you try on gentoo as well? Since 0.8.6 was working on FreeBSD+clang but not on Gentoo+gcc?

dimpase · 2017-04-04T09:17:47Z

comment:15

checking now on Linux. Will take a while---doing a clean rebuild of sage 8.0.beta...

dimpase · 2017-04-04T09:17:47Z

Changed branch from u/fbissey/brial-0.8.6 to u/dimpase/brial-0.8.6

dimpase · 2017-04-04T09:17:47Z

Changed commit from 0943ae5 to none

dimpase · 2017-04-04T16:49:40Z

comment:16

OK, it works on Linux too.
No idea why the branch is red though.

kiwifb · 2017-04-04T19:12:24Z

comment:17

Interesting message: "branch doesn't exist".

dimpase · 2017-04-04T20:46:07Z

comment:18

oops...

dimpase · 2017-04-04T20:46:07Z

Changed branch from u/dimpase/brial-0.8.6 to u/dimpase/brial086

dimpase · 2017-04-04T20:46:07Z

Commit: 382b25c

dimpase · 2017-04-04T21:51:18Z

Changed reviewer from François Bissey to François Bissey, Dima Pasechnik

dimpase · 2017-04-04T21:51:18Z

Changed author from Dima Pasechnik to François Bissey, Dima Pasechnik

vbraun · 2017-04-07T22:24:00Z

Changed branch from u/dimpase/brial086 to 382b25c

kiwifb added this to the sage-8.0 milestone Mar 24, 2017

kiwifb added c: porting labels Mar 24, 2017

This comment has been minimized.

Sign in to view

dimpase added the s: needs review label Mar 29, 2017

This comment has been minimized.

Sign in to view

kiwifb added s: needs work and removed s: needs review labels Mar 30, 2017

kiwifb added s: needs review and removed s: needs work labels Mar 30, 2017

dimpase added s: needs work and removed s: needs review labels Mar 30, 2017

This comment has been minimized.

Sign in to view

dimpase added s: needs review and removed s: needs work labels Apr 4, 2017

dimpase added s: positive review and removed s: needs review labels Apr 4, 2017

vbraun removed the s: positive review label Apr 7, 2017

vbraun closed this as completed in 2d52b91 Apr 7, 2017

Polybori segfaults when built with clang on OS X #22677

Polybori segfaults when built with clang on OS X #22677

Comments

kiwifb commented Mar 24, 2017

kiwifb commented Mar 24, 2017

kiwifb commented Mar 24, 2017

dimpase commented Mar 29, 2017

dimpase commented Mar 29, 2017

dimpase commented Mar 29, 2017

dimpase commented Mar 29, 2017

This comment has been minimized.

kiwifb commented Mar 30, 2017

kiwifb commented Mar 30, 2017

kiwifb commented Mar 30, 2017

This comment has been minimized.

kiwifb commented Mar 30, 2017

kiwifb commented Mar 30, 2017

kiwifb commented Mar 30, 2017

kiwifb commented Mar 30, 2017

dimpase commented Mar 30, 2017

kiwifb commented Mar 30, 2017

dimpase commented Mar 30, 2017

dimpase commented Mar 31, 2017

kiwifb commented Mar 31, 2017

kiwifb commented Apr 3, 2017

This comment has been minimized.

dimpase commented Apr 4, 2017

kiwifb commented Apr 4, 2017

dimpase commented Apr 4, 2017

dimpase commented Apr 4, 2017

dimpase commented Apr 4, 2017

dimpase commented Apr 4, 2017

kiwifb commented Apr 4, 2017

dimpase commented Apr 4, 2017

dimpase commented Apr 4, 2017

dimpase commented Apr 4, 2017

dimpase commented Apr 4, 2017

dimpase commented Apr 4, 2017

vbraun commented Apr 7, 2017